[v14,07/17] net: socket: Don't ignore EINVAL on netdev socket connection

Commit Message

Laurent Vivier Oct. 21, 2022, 9:09 a.m. UTC

From: Stefano Brivio <[e-mail]>

Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <[e-mail]>
Signed-off-by: Laurent Vivier <[e-mail]>
Reviewed-by: David Gibson <[e-mail]>
Acked-by: Michael S. Tsirkin <[e-mail]>
---
 net/socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/net/socket.c b/net/socket.c
index ade1ecf38b87..4944bb70d580 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -577,8 +577,7 @@  static int net_socket_connect_init(NetClientState *peer,
             if (errno == EINTR || errno == EWOULDBLOCK) {
                 /* continue */
             } else if (errno == EINPROGRESS ||
-                       errno == EALREADY ||
-                       errno == EINVAL) {
+                       errno == EALREADY) {
                 break;
             } else {
                 error_setg_errno(errp, errno, "can't connect socket");