| Message ID | 20221105115329.306527-1-mjt@msgid.tls.msk.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [trivial,for,7.2] hw/ssi/sifive_spi.c: spelling: reigster | expand |
Am 05.11.22 um 12:53 schrieb Michael Tokarev: > Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/ssi/sifive_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c > index 03540cf5ca..1b4a401ca1 100644 > --- a/hw/ssi/sifive_spi.c > +++ b/hw/ssi/sifive_spi.c > @@ -267,7 +267,7 @@ static void sifive_spi_write(void *opaque, hwaddr addr, > case R_RXDATA: > case R_IP: > qemu_log_mask(LOG_GUEST_ERROR, > - "%s: invalid write to read-only reigster 0x%" > + "%s: invalid write to read-only register 0x%" > HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); > break; > Reviewed-by: Stefan Weil <sw@weilnetz.de>
On Sat, Nov 5, 2022 at 9:54 PM Michael Tokarev <mjt@tls.msk.ru> wrote: > > Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/ssi/sifive_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c > index 03540cf5ca..1b4a401ca1 100644 > --- a/hw/ssi/sifive_spi.c > +++ b/hw/ssi/sifive_spi.c > @@ -267,7 +267,7 @@ static void sifive_spi_write(void *opaque, hwaddr addr, > case R_RXDATA: > case R_IP: > qemu_log_mask(LOG_GUEST_ERROR, > - "%s: invalid write to read-only reigster 0x%" > + "%s: invalid write to read-only register 0x%" > HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); > break; > > -- > 2.30.2 > >
On Sat, 05 Nov 2022 04:53:29 PDT (-0700), mjt@tls.msk.ru wrote: > Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 Not sure if I missed something in QEMU land, but those are usually listed more like Fixes: 0694dabe97 ("hw/ssi: Add SiFive SPI controller support") Checkpatch isn't failing, though. Either way Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> Thanks! > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/ssi/sifive_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c > index 03540cf5ca..1b4a401ca1 100644 > --- a/hw/ssi/sifive_spi.c > +++ b/hw/ssi/sifive_spi.c > @@ -267,7 +267,7 @@ static void sifive_spi_write(void *opaque, hwaddr addr, > case R_RXDATA: > case R_IP: > qemu_log_mask(LOG_GUEST_ERROR, > - "%s: invalid write to read-only reigster 0x%" > + "%s: invalid write to read-only register 0x%" > HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); > break;
On 8/11/22 23:11, Palmer Dabbelt wrote: > On Sat, 05 Nov 2022 04:53:29 PDT (-0700), mjt@tls.msk.ru wrote: >> Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 > > Not sure if I missed something in QEMU land, but those are usually > listed more like > > Fixes: 0694dabe97 ("hw/ssi: Add SiFive SPI controller support") MST suggested once to try to restrict the 'Fixes:' tag to bug / regressions, as it might help downstream distributions to filter commits to cherry-pick. Since it might be useful to have the offending commit sha1 in the description, when it is simply an omission or improvement I use the an inline form instead of a tag: Fixes the typo introduced in commit 0694dabe97 ("hw/ssi: Add SiFive SPI controller support"). Although in this particular use-case it is not really useful ;) Another example: When adding <the feature> in commit <sha1 ("<subject>")>, we forgot to fill the API prototype description. Do it now. Regards, Phil.
Le 05/11/2022 à 12:53, Michael Tokarev a écrit : > Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/ssi/sifive_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c > index 03540cf5ca..1b4a401ca1 100644 > --- a/hw/ssi/sifive_spi.c > +++ b/hw/ssi/sifive_spi.c > @@ -267,7 +267,7 @@ static void sifive_spi_write(void *opaque, hwaddr addr, > case R_RXDATA: > case R_IP: > qemu_log_mask(LOG_GUEST_ERROR, > - "%s: invalid write to read-only reigster 0x%" > + "%s: invalid write to read-only register 0x%" > HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); > break; > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/ssi/sifive_spi.c b/hw/ssi/sifive_spi.c index 03540cf5ca..1b4a401ca1 100644 --- a/hw/ssi/sifive_spi.c +++ b/hw/ssi/sifive_spi.c @@ -267,7 +267,7 @@ static void sifive_spi_write(void *opaque, hwaddr addr, case R_RXDATA: case R_IP: qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid write to read-only reigster 0x%" + "%s: invalid write to read-only register 0x%" HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); break;
Fixes: 0694dabe9763847f3010b54ab3ec7d367d2f0ff0 Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> --- hw/ssi/sifive_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)