diff mbox series

[2/6] target/ppc/mmu_common: Fix table layout of "info tlb" HMP command

Message ID 20221216145709.271940-3-shentey@gmail.com (mailing list archive)
State New, archived
Headers show
Series Trivial PPC cleanups | expand

Commit Message

Bernhard Beschow Dec. 16, 2022, 2:57 p.m. UTC
Starting with the URWX columns the columns didn't line up.
Before:

  QEMU 7.2.50 monitor - type 'help' for more information
  (qemu) info tlb

  TLB0:
  Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
  0x0000000000a80000 0x000000000105d000   4K 117   0  SR--UR-- --M-- U----
  0x0000000000100000 0x000000000114e000   4K 117   0  SR--UR-- --M-- U----
  <snip

  TLB1:
  Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
  0x00000000c0000000 0x0000000000000000  16M 0     0  SR-XU--- --M-- U----
  0x00000000c1000000 0x0000000001000000  16M 0     0  SRW-U--- --M-- U----
  <snip>
  (qemu)

After:

  QEMU 7.2.50 monitor - type 'help' for more information
  (qemu) info tlb

  TLB0:
  Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
  0x00000000b7a00000 0x000000000fcf5000   4K 18    0  SR-- UR-- --M-- U----
  0x0000000000800000 0x000000000fd73000   4K 18    0  SR-- UR-X --M-- U----
  <snip>

  TLB1:
  Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
  0x00000000c0000000 0x0000000000000000  16M 0     0  SR-X U--- --M-- U----
  0x00000000c1000000 0x0000000001000000  16M 0     0  SRW- U--- --M-- U----
  <snip>
  (qemu)

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 target/ppc/mmu_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Dec. 16, 2022, 4:24 p.m. UTC | #1
On 16/12/22 15:57, Bernhard Beschow wrote:
> Starting with the URWX columns the columns didn't line up.
> Before:
> 
>    QEMU 7.2.50 monitor - type 'help' for more information
>    (qemu) info tlb
> 
>    TLB0:
>    Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
>    0x0000000000a80000 0x000000000105d000   4K 117   0  SR--UR-- --M-- U----
>    0x0000000000100000 0x000000000114e000   4K 117   0  SR--UR-- --M-- U----
>    <snip
> 
>    TLB1:
>    Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
>    0x00000000c0000000 0x0000000000000000  16M 0     0  SR-XU--- --M-- U----
>    0x00000000c1000000 0x0000000001000000  16M 0     0  SRW-U--- --M-- U----
>    <snip>
>    (qemu)
> 
> After:
> 
>    QEMU 7.2.50 monitor - type 'help' for more information
>    (qemu) info tlb
> 
>    TLB0:
>    Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
>    0x00000000b7a00000 0x000000000fcf5000   4K 18    0  SR-- UR-- --M-- U----
>    0x0000000000800000 0x000000000fd73000   4K 18    0  SR-- UR-X --M-- U----
>    <snip>
> 
>    TLB1:
>    Effective          Physical           Size TID   TS SRWX URWX WIMGE U0123
>    0x00000000c0000000 0x0000000000000000  16M 0     0  SR-X U--- --M-- U----
>    0x00000000c1000000 0x0000000001000000  16M 0     0  SRW- U--- --M-- U----
>    <snip>
>    (qemu)
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   target/ppc/mmu_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 49067c05e6..8901f4d134 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -980,7 +980,7 @@  static void mmubooke206_dump_one_tlb(CPUPPCState *env, int tlbn, int offset,
         pa = entry->mas7_3 & ~(size - 1);
 
         qemu_printf("0x%016" PRIx64 " 0x%016" PRIx64 " %4s %-5u %1u  S%c%c%c"
-                    "U%c%c%c %c%c%c%c%c U%c%c%c%c\n",
+                    " U%c%c%c %c%c%c%c%c U%c%c%c%c\n",
                     (uint64_t)ea, (uint64_t)pa,
                     book3e_tsize_to_str[tsize],
                     (entry->mas1 & MAS1_TID_MASK) >> MAS1_TID_SHIFT,