diff mbox series

[3/6] hw/ppc/virtex_ml507: Prefer local over global variable

Message ID 20221216145709.271940-4-shentey@gmail.com (mailing list archive)
State New, archived
Headers show
Series Trivial PPC cleanups | expand

Commit Message

Bernhard Beschow Dec. 16, 2022, 2:57 p.m. UTC 
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/ppc/virtex_ml507.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Edgar E. Iglesias Dec. 16, 2022, 3:54 p.m. UTC | #1 
On Fri, Dec 16, 2022 at 03:57:06PM +0100, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>


> ---
>  hw/ppc/virtex_ml507.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 13cace229b..f2f81bd425 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -157,7 +157,7 @@ static int xilinx_load_device_tree(MachineState *machine,
>      int r;
>      const char *dtb_filename;
>  
> -    dtb_filename = current_machine->dtb;
> +    dtb_filename = machine->dtb;
>      if (dtb_filename) {
>          fdt = load_device_tree(dtb_filename, &fdt_size);
>          if (!fdt) {
> -- 
> 2.39.0
>
Philippe Mathieu-Daudé Dec. 16, 2022, 4:28 p.m. UTC | #2 
On 16/12/22 15:57, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/ppc/virtex_ml507.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 13cace229b..f2f81bd425 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -157,7 +157,7 @@ static int xilinx_load_device_tree(MachineState *machine,
>       int r;
>       const char *dtb_filename;
>   
> -    dtb_filename = current_machine->dtb;
> +    dtb_filename = machine->dtb;

https://lore.kernel.org/qemu-devel/20200109152133.23649-1-philmd@redhat.com/

\o/

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index 13cace229b..f2f81bd425 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -157,7 +157,7 @@  static int xilinx_load_device_tree(MachineState *machine,
     int r;
     const char *dtb_filename;
 
-    dtb_filename = current_machine->dtb;
+    dtb_filename = machine->dtb;
     if (dtb_filename) {
         fdt = load_device_tree(dtb_filename, &fdt_size);
         if (!fdt) {