From patchwork Sun Dec 18 17:15:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Volker_R=C3=BCmelin?= X-Patchwork-Id: 13076066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2364CC4332F for ; Sun, 18 Dec 2022 17:17:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6xGk-0007nL-Bz; Sun, 18 Dec 2022 12:16:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6xGg-0007gI-K5 for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:16:06 -0500 Received: from mailout08.t-online.de ([194.25.134.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6xGf-0002XX-1x for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:16:06 -0500 Received: from fwd86.dcpf.telekom.de (fwd86.aul.t-online.de [10.223.144.112]) by mailout08.t-online.de (Postfix) with SMTP id 552754D9D; Sun, 18 Dec 2022 18:15:44 +0100 (CET) Received: from linpower.localnet ([79.208.21.92]) by fwd86.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1p6xGH-12kBwv0; Sun, 18 Dec 2022 18:15:41 +0100 Received: by linpower.localnet (Postfix, from userid 1000) id 143FE20045A; Sun, 18 Dec 2022 18:15:39 +0100 (CET) From: =?utf-8?q?Volker_R=C3=BCmelin?= To: Gerd Hoffmann Cc: Christian Schoenebeck , Thomas Huth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Subject: [PATCH 02/11] audio: don't show unnecessary error messages Date: Sun, 18 Dec 2022 18:15:30 +0100 Message-Id: <20221218171539.11193-2-vr_qemu@t-online.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <3b1404eb-a7c5-f64c-3e47-1397c54c45bb@t-online.de> References: <3b1404eb-a7c5-f64c-3e47-1397c54c45bb@t-online.de> MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1671383741-D9A4E9D3-8DBE0184/0/0 CLEAN NORMAL X-TOI-MSGID: 293c7602-e4a2-4123-a5da-c2ae87c1a525 Received-SPF: none client-ip=194.25.134.20; envelope-from=volker.ruemelin@t-online.de; helo=mailout08.t-online.de X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Let the audio_pcm_create_voice_pair_* functions handle error reporting. This avoids an additional error message in case the guest selected an unimplemented sample rate. Signed-off-by: Volker Rümelin Reviewed-by: Philippe Mathieu-Daudé --- audio/audio_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index bfa94b4d22..ee320a2e3f 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -421,6 +421,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)( hw = glue(audio_pcm_hw_add_, TYPE)(s, &hw_as); if (!hw) { + dolog("Could not create a backend for voice `%s'\n", sw_name); goto err2; } @@ -520,7 +521,6 @@ SW *glue (AUD_open_, TYPE) ( } else { sw = glue(audio_pcm_create_voice_pair_, TYPE)(s, name, as); if (!sw) { - dolog ("Failed to create voice `%s'\n", name); return NULL; } }