| Message ID | 20221227064812.1903326-7-bmeng@tinylab.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/riscv: Improve Spike HTIF emulation fidelity | expand |
On 12/27/22 03:48, Bin Meng wrote: > There are forward declarations for 'vmstate_htif' and 'htif_io_ops' > in riscv_htif.h however there are no definitions in the C codes. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > > include/hw/char/riscv_htif.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h > index 55cc352331..9e8ebbe017 100644 > --- a/include/hw/char/riscv_htif.h > +++ b/include/hw/char/riscv_htif.h > @@ -40,9 +40,6 @@ typedef struct HTIFState { > uint64_t pending_read; > } HTIFState; > > -extern const VMStateDescription vmstate_htif; > -extern const MemoryRegionOps htif_io_ops; > - > /* HTIF symbol callback */ > void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_value, > uint64_t st_size);
On Tue, Dec 27, 2022 at 4:56 PM Bin Meng <bmeng@tinylab.org> wrote: > > There are forward declarations for 'vmstate_htif' and 'htif_io_ops' > in riscv_htif.h however there are no definitions in the C codes. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > include/hw/char/riscv_htif.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h > index 55cc352331..9e8ebbe017 100644 > --- a/include/hw/char/riscv_htif.h > +++ b/include/hw/char/riscv_htif.h > @@ -40,9 +40,6 @@ typedef struct HTIFState { > uint64_t pending_read; > } HTIFState; > > -extern const VMStateDescription vmstate_htif; > -extern const MemoryRegionOps htif_io_ops; > - > /* HTIF symbol callback */ > void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_value, > uint64_t st_size); > -- > 2.34.1 > >
diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h index 55cc352331..9e8ebbe017 100644 --- a/include/hw/char/riscv_htif.h +++ b/include/hw/char/riscv_htif.h @@ -40,9 +40,6 @@ typedef struct HTIFState { uint64_t pending_read; } HTIFState; -extern const VMStateDescription vmstate_htif; -extern const MemoryRegionOps htif_io_ops; - /* HTIF symbol callback */ void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_value, uint64_t st_size);
There are forward declarations for 'vmstate_htif' and 'htif_io_ops' in riscv_htif.h however there are no definitions in the C codes. Signed-off-by: Bin Meng <bmeng@tinylab.org> --- include/hw/char/riscv_htif.h | 3 --- 1 file changed, 3 deletions(-)