diff mbox series

[2/4] util/qht: add missing atomic_set(hashes[i])

Message ID 20230108163905.59601-3-cota@braap.org (mailing list archive)
State New, archived
Headers show
Series tsan fixes | expand

Commit Message

Emilio Cota Jan. 8, 2023, 4:39 p.m. UTC 
We forgot to add this one in "a890643958 util/qht: atomically set b->hashes".

Detected with tsan.

Signed-off-by: Emilio Cota <cota@braap.org>
---
 util/qht.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson Jan. 8, 2023, 7:20 p.m. UTC | #1 
On 1/8/23 08:39, Emilio Cota wrote:
> We forgot to add this one in "a890643958 util/qht: atomically set b->hashes".
> 
> Detected with tsan.
> 
> Signed-off-by: Emilio Cota<cota@braap.org>
> ---
>   util/qht.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Philippe Mathieu-Daudé Jan. 8, 2023, 7:54 p.m. UTC | #2 
On 8/1/23 17:39, Emilio Cota wrote:
> We forgot to add this one in "a890643958 util/qht: atomically set b->hashes".
> 
> Detected with tsan.
> 
> Signed-off-by: Emilio Cota <cota@braap.org>
> ---
>   util/qht.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/util/qht.c b/util/qht.c
index 065fc501f4..15866299e6 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -688,7 +688,7 @@  static inline void qht_bucket_remove_entry(struct qht_bucket *orig, int pos)
     int i;
 
     if (qht_entry_is_last(orig, pos)) {
-        orig->hashes[pos] = 0;
+        qatomic_set(&orig->hashes[pos], 0);
         qatomic_set(&orig->pointers[pos], NULL);
         return;
     }