| Message ID | 20230119065959.3104012-11-armbru@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Clean up includes | expand |
* Markus Armbruster (armbru@redhat.com) wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. That change doesn't seem to match the message; the patch is removing the osdep.h include. Dave > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > include/qemu/userfaultfd.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/qemu/userfaultfd.h b/include/qemu/userfaultfd.h > index 6b74f92792..55c95998e8 100644 > --- a/include/qemu/userfaultfd.h > +++ b/include/qemu/userfaultfd.h > @@ -13,7 +13,6 @@ > #ifndef USERFAULTFD_H > #define USERFAULTFD_H > > -#include "qemu/osdep.h" > #include "exec/hwaddr.h" > #include <linux/userfaultfd.h> > > -- > 2.39.0 >
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: > * Markus Armbruster (armbru@redhat.com) wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. > > That change doesn't seem to match the message; the patch is removing the > osdep.h include. It's the commit message scripts/clean-includes creates :) I can throw in another patch to the script so it mentions it also removes qemu/osdep.h from headers. >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> --- >> include/qemu/userfaultfd.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/qemu/userfaultfd.h b/include/qemu/userfaultfd.h >> index 6b74f92792..55c95998e8 100644 >> --- a/include/qemu/userfaultfd.h >> +++ b/include/qemu/userfaultfd.h >> @@ -13,7 +13,6 @@ >> #ifndef USERFAULTFD_H >> #define USERFAULTFD_H >> >> -#include "qemu/osdep.h" >> #include "exec/hwaddr.h" >> #include <linux/userfaultfd.h> >> >> -- >> 2.39.0 >>
* Markus Armbruster (armbru@redhat.com) wrote: > "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: > > > * Markus Armbruster (armbru@redhat.com) wrote: > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > > > > That change doesn't seem to match the message; the patch is removing the > > osdep.h include. > > It's the commit message scripts/clean-includes creates :) > > I can throw in another patch to the script so it mentions it also > removes qemu/osdep.h from headers. Oh hmm it would be clearer; but OK then, so Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > >> This commit was created with scripts/clean-includes. > >> > >> Signed-off-by: Markus Armbruster <armbru@redhat.com> > >> --- > >> include/qemu/userfaultfd.h | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/include/qemu/userfaultfd.h b/include/qemu/userfaultfd.h > >> index 6b74f92792..55c95998e8 100644 > >> --- a/include/qemu/userfaultfd.h > >> +++ b/include/qemu/userfaultfd.h > >> @@ -13,7 +13,6 @@ > >> #ifndef USERFAULTFD_H > >> #define USERFAULTFD_H > >> > >> -#include "qemu/osdep.h" > >> #include "exec/hwaddr.h" > >> #include <linux/userfaultfd.h> > >> > >> -- > >> 2.39.0 > >> >
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: > * Markus Armbruster (armbru@redhat.com) wrote: >> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: >> >> > * Markus Armbruster (armbru@redhat.com) wrote: >> >> Clean up includes so that osdep.h is included first and headers >> >> which it implies are not included manually. >> > >> > That change doesn't seem to match the message; the patch is removing the >> > osdep.h include. >> >> It's the commit message scripts/clean-includes creates :) >> >> I can throw in another patch to the script so it mentions it also >> removes qemu/osdep.h from headers. > > Oh hmm it would be clearer; What about $GITSUBJ: Clean up includes Clean up includes so that osdep.h is included first in .c and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. > but OK then, so > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Thanks!
Markus Armbruster <armbru@redhat.com> wrote: > "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: > >> * Markus Armbruster (armbru@redhat.com) wrote: >>> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes: >>> >>> > * Markus Armbruster (armbru@redhat.com) wrote: >>> >> Clean up includes so that osdep.h is included first and headers >>> >> which it implies are not included manually. >>> > >>> > That change doesn't seem to match the message; the patch is removing the >>> > osdep.h include. >>> >>> It's the commit message scripts/clean-includes creates :) >>> >>> I can throw in another patch to the script so it mentions it also >>> removes qemu/osdep.h from headers. >> >> Oh hmm it would be clearer; > > What about > > $GITSUBJ: Clean up includes > > Clean up includes so that osdep.h is included first in .c and not in > .h, and headers which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > >> but OK then, so >> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Sounds ok to me. Reviewed-by: Juan Quintela <quintela@redhat.com>
diff --git a/include/qemu/userfaultfd.h b/include/qemu/userfaultfd.h index 6b74f92792..55c95998e8 100644 --- a/include/qemu/userfaultfd.h +++ b/include/qemu/userfaultfd.h @@ -13,7 +13,6 @@ #ifndef USERFAULTFD_H #define USERFAULTFD_H -#include "qemu/osdep.h" #include "exec/hwaddr.h" #include <linux/userfaultfd.h>
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- include/qemu/userfaultfd.h | 1 - 1 file changed, 1 deletion(-)