| Message ID | 20230125102053.902098-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | docs/about/deprecated: Mark HAXM as deprecated | expand |
On 25/1/23 11:20, Thomas Huth wrote: > The HAXM project has been retired (see https://github.com/intel/haxm#status), > so we should mark the code in QEMU as deprecated (and finally remove it > unless somebody else picks the project up again - which is quite unlikely > since there are now whpx and hvf on these operating systems, too). > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > docs/about/deprecated.rst | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Wed, Jan 25, 2023 at 11:20:53AM +0100, Thomas Huth wrote: > The HAXM project has been retired (see https://github.com/intel/haxm#status), > so we should mark the code in QEMU as deprecated (and finally remove it > unless somebody else picks the project up again - which is quite unlikely > since there are now whpx and hvf on these operating systems, too). > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > docs/about/deprecated.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 3f4d678eb4..da2e6fe63d 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -93,6 +93,12 @@ form is preferred. > The HPET setting has been turned into a machine property. > Use ``-machine hpet=off`` instead. > > +``-accel hax`` (since 8.0) > +'''''''''''''''''''''''''' > + > +The HAXM project has been retired (see https://github.com/intel/haxm#status). > +Use "whpx" (on Windows) or "hvf" (on macOS) instead. > + Should we print a warning message from meson when someone enables this ? We've tended to do that when we've deprecated other platforms in the past, though not consistently > QEMU Machine Protocol (QMP) commands > ------------------------------------ > -- > 2.31.1 > > With regards, Daniel
On 25/01/2023 13.09, Daniel P. Berrangé wrote: > On Wed, Jan 25, 2023 at 11:20:53AM +0100, Thomas Huth wrote: >> The HAXM project has been retired (see https://github.com/intel/haxm#status), >> so we should mark the code in QEMU as deprecated (and finally remove it >> unless somebody else picks the project up again - which is quite unlikely >> since there are now whpx and hvf on these operating systems, too). >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> docs/about/deprecated.rst | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >> index 3f4d678eb4..da2e6fe63d 100644 >> --- a/docs/about/deprecated.rst >> +++ b/docs/about/deprecated.rst >> @@ -93,6 +93,12 @@ form is preferred. >> The HPET setting has been turned into a machine property. >> Use ``-machine hpet=off`` instead. >> >> +``-accel hax`` (since 8.0) >> +'''''''''''''''''''''''''' >> + >> +The HAXM project has been retired (see https://github.com/intel/haxm#status). >> +Use "whpx" (on Windows) or "hvf" (on macOS) instead. >> + > > Should we print a warning message from meson when someone enables this ? Or maybe rather to hax_accel_init() , so that people who run the binary see the message? ... I can add it there (though I have no means of testing it). Thomas
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 3f4d678eb4..da2e6fe63d 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -93,6 +93,12 @@ form is preferred. The HPET setting has been turned into a machine property. Use ``-machine hpet=off`` instead. +``-accel hax`` (since 8.0) +'''''''''''''''''''''''''' + +The HAXM project has been retired (see https://github.com/intel/haxm#status). +Use "whpx" (on Windows) or "hvf" (on macOS) instead. + QEMU Machine Protocol (QMP) commands ------------------------------------
The HAXM project has been retired (see https://github.com/intel/haxm#status), so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too). Signed-off-by: Thomas Huth <thuth@redhat.com> --- docs/about/deprecated.rst | 6 ++++++ 1 file changed, 6 insertions(+)