diff mbox series

[v2,06/10] hw/ide/pci: Add PCIIDEState::isa_irqs[]

Message ID 20230126211740.66874-7-shentey@gmail.com (mailing list archive)
State New, archived
Headers show
Series Resolve isabus global | expand

Commit Message

Bernhard Beschow Jan. 26, 2023, 9:17 p.m. UTC
These legacy ISA IRQs allow the PIIX IDE functions to be wired up in
their south bridges and the VIA IDE functions to disuse
PCI_INTERRUPT_LINE as outlined in https://lists.nongnu.org/archive/html/
qemu-devel/2020-03/msg01707.html .

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 include/hw/ide/pci.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Bernhard Beschow Jan. 30, 2023, 5 p.m. UTC | #1
Am 26. Januar 2023 21:17:36 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>These legacy ISA IRQs allow the PIIX IDE functions to be wired up in
>their south bridges and the VIA IDE functions to disuse
>PCI_INTERRUPT_LINE as outlined in https://lists.nongnu.org/archive/html/
>qemu-devel/2020-03/msg01707.html .
>

Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

>Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>---
> include/hw/ide/pci.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h
>index 2a6284acac..24c0b7a2dd 100644
>--- a/include/hw/ide/pci.h
>+++ b/include/hw/ide/pci.h
>@@ -49,6 +49,7 @@ struct PCIIDEState {
> 
>     IDEBus bus[2];
>     BMDMAState bmdma[2];
>+    qemu_irq isa_irqs[2];
>     uint32_t secondary; /* used only for cmd646 */
>     MemoryRegion bmdma_bar;
>     MemoryRegion cmd_bar[2];
Philippe Mathieu-Daudé Feb. 26, 2023, 9:26 p.m. UTC | #2
On 30/1/23 18:00, Bernhard Beschow wrote:
> 
> 
> Am 26. Januar 2023 21:17:36 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>> These legacy ISA IRQs allow the PIIX IDE functions to be wired up in
>> their south bridges and the VIA IDE functions to disuse
>> PCI_INTERRUPT_LINE as outlined in https://lists.nongnu.org/archive/html/
>> qemu-devel/2020-03/msg01707.html .
>>
> 
> Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>> ---
>> include/hw/ide/pci.h | 1 +
>> 1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h
index 2a6284acac..24c0b7a2dd 100644
--- a/include/hw/ide/pci.h
+++ b/include/hw/ide/pci.h
@@ -49,6 +49,7 @@  struct PCIIDEState {
 
     IDEBus bus[2];
     BMDMAState bmdma[2];
+    qemu_irq isa_irqs[2];
     uint32_t secondary; /* used only for cmd646 */
     MemoryRegion bmdma_bar;
     MemoryRegion cmd_bar[2];