From patchwork Sun Feb 5 04:07:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Bulekov X-Patchwork-Id: 13128956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5B0AC636CC for ; Sun, 5 Feb 2023 04:09:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOWKj-0000Qp-L9; Sat, 04 Feb 2023 23:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOWKg-0000Om-79 for qemu-devel@nongnu.org; Sat, 04 Feb 2023 23:08:50 -0500 Received: from esa9.hc2706-39.iphmx.com ([216.71.140.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOWKd-0002lX-G9 for qemu-devel@nongnu.org; Sat, 04 Feb 2023 23:08:49 -0500 X-IronPort-RemoteIP: 209.85.166.198 X-IronPort-MID: 256812067 X-IronPort-Reputation: None X-IronPort-Listener: OutgoingMail X-IronPort-SenderGroup: RELAY_GSUITE X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Pq0FJavVxtLTU+QPETg14oO4c+fnVOhcMUV32f8akzHdYApBsoF/q tZmKWqBPaqLY2unc4siYI3kpksOsMCGm9RnS1Zo/CljFyga9ZOVVN+UEBzMMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZmOagQ1LPjvyJ94Kw3dPnZw0TQH9E88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IPM0SQqkEqSh8ai87XAMEhhXJ/0F1lqTzQJ OJl7vRcQS9xVkHFdX90vxNwSkmSNoUfkFPLzOTWXWV+ACQqflO1q8iCAn3aMqU09flFX2981 8UoNRELTR2klfyZ0rKkH7wEasQLdKEHPasas3BkiDDdVLMoGMGTBarN4tBc0XE7gcUm8fT2P ZJIL2oyKk2ePVsWawd/5JEWxY9EglH2dy1epEi9r7dx7mTOpOB0+OKwboqMIITUGq25mG7B+ GTaon/HLS0mE/KV2Tioy3SKlP7myHaTtIU6UefQGuRRqESew3FWBBAIWF+Tp/6/hUijHdVFJ CQpFjEGqKEz8AmqSoC4UUTp8DiLuRkTX9cWGOo/gO2Q9pfpD8+iLjBsZlZ8hBYO7qfamRRCO oe1ou7U IronPort-HdrOrdr: A9a23:Zjp6wKtJi4lsHS8A7qulpuGu7skDpdV00zEX/kB9WHVpm62j5q eTdZEguyMc5wxxZJgfo6H6BEDtexPhHP1OkO0s1NWZLWvbUQKTRekI0WKI+UyEJ8SRzJ8/6U 8ZGZIOceEZCjBB4PoTt2GDYqwdKMvuysyVbfS39QYRcShaL5xt6x59AhuWe3cGPDWvFfICfq Z1/KJ8yAZJAB4sH6KGOkU= Received: from mail-il1-f198.google.com ([209.85.166.198]) by ob1.hc2706-39.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Feb 2023 23:08:46 -0500 Received: by mail-il1-f198.google.com with SMTP id i23-20020a056e021d1700b003111192e89aso5898490ila.10 for ; Sat, 04 Feb 2023 20:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bu.edu; s=s1gsbu; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xaj0P5NfDOj0aUUjOgS+QNvT8LrWmHCX1h2HgFRSCw8=; b=iaWD72LH/CAletQXbBr1KVCUHAxY1DGpPgSf59OI6axHIFaR8cNzb4KT1K9Y1Rw+KY FUJN7JaA5bcjVfKKnLphqFdxmhq8OoWCFuePnD1scVMmm2TP3v4szAtu040z9HFlAxJi VNIwgKVbQH/OIlRmKU//2V1HocqPUolJgu6fR9K6jTmHDzaanXLNTup2zIUJT1KeT+ej mbsGdElbfHEF3YoWKgf4q+Jhn2fPgQNeEdPyi6vhD3BSaHbGutRcet1GaHW+c/P5oyv6 3y7Hk48hgs+jMrHY6maTWbVqocREgyVJDcQ0gia5nm/1VllpGxE6L4oDqlB0CB68FgGU bAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xaj0P5NfDOj0aUUjOgS+QNvT8LrWmHCX1h2HgFRSCw8=; b=e5sq0SFnSyDTcykfGBvRCvEYOfmEmiOl9gnPxHzDz2vhao2CX4QyDSk35r9riPowuD Dh4uZbFMBcMU8yivKfel2+pWw/1P/iWWeA3TurM6GMpuS6aOcIi2K58omkkIwu5c06PK uzqnra4ZRMeIT3bDOM7lU3aoHjCxw+B6tHqHNzNujsiPErmRrEcJmqiX4NfeGhr2/kYq 2n2sTsQ6GW671NO/O4UBcQ3zOtCx2KcOh4lSvpWQM6KiH1aeGgb+w0e9PJ/ZyG04nlMd hoRULP/7Ga1wQVtS/yqAz9SFPf6pgyShse+GtldkLNxZpundsYC17qYsiaRTizjMf0I+ Enbg== X-Gm-Message-State: AO0yUKVwroY2pbklUu5/LwpUZskqNAEu45nSiMhnZZBeJNz/JtHWmyKR jIMHwpFJoGiS9f9G2Nr4+QSjdQ2Q+sH7Hb/+IpGAQU7i4d2j+YUX2gDeMGBMgJ3mZZ2vk/HxxEj H6a1qZtB7qA4xUdJMlly9k0VSWL4bPg== X-Received: by 2002:ac8:7f4e:0:b0:3b8:6c8e:4f8d with SMTP id g14-20020ac87f4e000000b003b86c8e4f8dmr29735341qtk.68.1675570114446; Sat, 04 Feb 2023 20:08:34 -0800 (PST) X-Google-Smtp-Source: AK7set9mVHm/Tk+DydRlTWDKhXZMECv1AAgq7duHEV6Bv94/D3oL7YUPLYNrpnvegLZrmMkGMcNnvg== X-Received: by 2002:ac8:7f4e:0:b0:3b8:6c8e:4f8d with SMTP id g14-20020ac87f4e000000b003b86c8e4f8dmr29735322qtk.68.1675570114193; Sat, 04 Feb 2023 20:08:34 -0800 (PST) Received: from mozz.bu.edu (mozz.bu.edu. [128.197.127.33]) by smtp.gmail.com with ESMTPSA id o2-20020a05620a0d4200b00731c30ac2e8sm1387104qkl.74.2023.02.04.20.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Feb 2023 20:08:33 -0800 (PST) From: Alexander Bulekov To: qemu-devel@nongnu.org Cc: Alexander Bulekov , Stefan Hajnoczi , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Mauro Matteo Cascella , Peter Xu , Jason Wang , David Hildenbrand , Gerd Hoffmann , Thomas Huth , Laurent Vivier , Bandan Das , "Edgar E . Iglesias" , Darren Kenny , Bin Meng , Paolo Bonzini , "Michael S . Tsirkin" , Marcel Apfelbaum , =?utf-8?q?Daniel_P_=2E_Berra?= =?utf-8?q?ng=C3=A9?= , Eduardo Habkost , Jon Maloy , Siqi Chen Subject: [PATCH v6 3/4] checkpatch: add qemu_bh_new/aio_bh_new checks Date: Sat, 4 Feb 2023 23:07:36 -0500 Message-Id: <20230205040737.3567731-4-alxndr@bu.edu> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230205040737.3567731-1-alxndr@bu.edu> References: <20230205040737.3567731-1-alxndr@bu.edu> MIME-Version: 1.0 X-CES-GSUITE_AUTH: bf3aNvsZpxl8 Received-SPF: pass client-ip=216.71.140.197; envelope-from=alxndr@bu.edu; helo=esa9.hc2706-39.iphmx.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Advise authors to use the _guarded versions of the APIs, instead. Reviewed-by: Darren Kenny Signed-off-by: Alexander Bulekov --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6ecabfb2b5..fbb71c70f8 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2865,6 +2865,14 @@ sub process { if ($line =~ /\bsignal\s*\(/ && !($line =~ /SIG_(?:IGN|DFL)/)) { ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr); } +# recommend qemu_bh_new_guarded instead of qemu_bh_new + if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\bqemu_bh_new\s*\(/) { + ERROR("use qemu_bh_new_guarded() instead of qemu_bh_new() to avoid reentrancy problems\n" . $herecurr); + } +# recommend aio_bh_new_guarded instead of aio_bh_new + if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\baio_bh_new\s*\(/) { + ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentrancy problems\n" . $herecurr); + } # check for module_init(), use category-specific init macros explicitly please if ($line =~ /^module_init\s*\(/) { ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr);