From patchwork Mon Feb 6 14:08:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 13130013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80E39C61DA4 for ; Mon, 6 Feb 2023 14:14:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP2Cd-00064m-VC; Mon, 06 Feb 2023 09:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP2Cb-00063m-V9 for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:38 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP2Ca-0002f1-GG for qemu-devel@nongnu.org; Mon, 06 Feb 2023 09:10:37 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CFE0E20E1B; Mon, 6 Feb 2023 14:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675692634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxPdLXH9DmKt7VkrYzZg7R/L6jDlTL/4xksbd9VouN0=; b=Mpk0FuTZJ9jEnMggUYmhDpj/LqgZEe01oSRze1xGqLzcOeR4PSRvM4NraQvfAUR8p5oA2+ 3Uxn+Vzfg/T4lhueLSPuAOJy8L7EqVkvQ6UcG2roH6k7DzycCzl491uOvinTf+WN6udF55 nfq8gp51QajQ8XFMXp/G4Mi7x0QRzOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675692634; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxPdLXH9DmKt7VkrYzZg7R/L6jDlTL/4xksbd9VouN0=; b=jvK2cECAS6HqRUij46JH6wlXbzWGKI98yh5aaa4Z+IZoriWJ4PU2L4vT0NOBsT/pBfW/4B Rk3L43TQgJdOy/Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C7506138E7; Mon, 6 Feb 2023 14:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eEhsI1gK4WOgQAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 14:10:32 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PATCH 03/10] hw/i386: Select VGA_PCI in Kconfig Date: Mon, 6 Feb 2023 11:08:02 -0300 Message-Id: <20230206140809.26028-4-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230206140809.26028-1-farosas@suse.de> References: <20230206140809.26028-1-farosas@suse.de> MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Machines that have "std" as default VGA display need to always build vga-pci.c, otherwise we get a crash when CONFIG_PCI_DEVICES=n: $ ./qemu-system-x86_64 -M q35 -vga std qemu-system-x86_64: unknown type 'VGA' Aborted (core dumped) Signed-off-by: Fabiano Rosas --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 527b95df81..8e59cb6634 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -30,9 +30,9 @@ config PC imply TEST_DEVICES imply TPM_CRB imply TPM_TIS_ISA - imply VGA_PCI imply VIRTIO_VGA imply NVDIMM + select VGA_PCI select FDC_ISA select I8259 select I8254