| Message ID | 20230207075115.1525-3-armbru@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | error: Reduce qerror.h usage a bit more | expand |
On 7/2/23 08:51, Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague > error message > > (qemu) dump-guest-memory mumble > Error: this feature or command is not currently supported > > to > > Error: guest memory dumping is not supported on this target > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > dump/dump.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dump/dump.c b/dump/dump.c > index 279b07f09b..80620da40d 100644 > --- a/dump/dump.c > +++ b/dump/dump.c > @@ -1854,7 +1854,8 @@ static void dump_init(DumpState *s, int fd, bool has_format, > */ > ret = cpu_get_dump_info(&s->dump_info, &s->guest_phys_blocks); > if (ret < 0) { > - error_setg(errp, QERR_UNSUPPORTED); > + error_setg(errp, > + "guest memory dumping is not supported on this target"); "Dumping guest memory is not supported on this target"? > goto cleanup; > } >
Markus Armbruster <armbru@redhat.com> wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague > error message > > (qemu) dump-guest-memory mumble > Error: this feature or command is not currently supported > > to > > Error: guest memory dumping is not supported on this target > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Both your and philippe message are ok with me.
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > On 7/2/23 08:51, Markus Armbruster wrote: >> The QERR_ macros are leftovers from the days of "rich" error objects. >> We've been trying to reduce their remaining use. >> Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague >> error message >> (qemu) dump-guest-memory mumble >> Error: this feature or command is not currently supported >> to >> Error: guest memory dumping is not supported on this target >> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> --- >> dump/dump.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> diff --git a/dump/dump.c b/dump/dump.c >> index 279b07f09b..80620da40d 100644 >> --- a/dump/dump.c >> +++ b/dump/dump.c >> @@ -1854,7 +1854,8 @@ static void dump_init(DumpState *s, int fd, bool has_format, >> */ >> ret = cpu_get_dump_info(&s->dump_info, &s->guest_phys_blocks); >> if (ret < 0) { >> - error_setg(errp, QERR_UNSUPPORTED); >> + error_setg(errp, >> + "guest memory dumping is not supported on this target"); > > "Dumping guest memory is not supported on this target"? Sold! >> goto cleanup; >> } >>
diff --git a/dump/dump.c b/dump/dump.c index 279b07f09b..80620da40d 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1854,7 +1854,8 @@ static void dump_init(DumpState *s, int fd, bool has_format, */ ret = cpu_get_dump_info(&s->dump_info, &s->guest_phys_blocks); if (ret < 0) { - error_setg(errp, QERR_UNSUPPORTED); + error_setg(errp, + "guest memory dumping is not supported on this target"); goto cleanup; }
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague error message (qemu) dump-guest-memory mumble Error: this feature or command is not currently supported to Error: guest memory dumping is not supported on this target Signed-off-by: Markus Armbruster <armbru@redhat.com> --- dump/dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)