| Message ID | 20230225063527.281479-4-gshan@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | NUMA: Apply cluster-NUMA-node boundary for aarch64 and riscv machines | expand |
On 2/25/23 03:35, Gavin Shan wrote: > There are two RISCV machines where NUMA is aware: 'virt' and 'spike'. > Both of them are required to follow cluster-NUMA-node boundary. To > enable the validation to warn about the irregular configuration where > multiple CPUs in one cluster has been associated with multiple NUMA > nodes. > > Signed-off-by: Gavin Shan <gshan@redhat.com> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > hw/riscv/spike.c | 2 ++ > hw/riscv/virt.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c > index cc3f6dac17..b09b993634 100644 > --- a/hw/riscv/spike.c > +++ b/hw/riscv/spike.c > @@ -357,6 +357,8 @@ static void spike_machine_class_init(ObjectClass *oc, void *data) > mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; > mc->get_default_cpu_node_id = riscv_numa_get_default_cpu_node_id; > mc->numa_mem_supported = true; > + /* platform instead of architectural choice */ > + mc->cpu_cluster_has_numa_boundary = true; > mc->default_ram_id = "riscv.spike.ram"; > } > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index b81081c70b..e5bb168169 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -1636,6 +1636,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) > mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; > mc->get_default_cpu_node_id = riscv_numa_get_default_cpu_node_id; > mc->numa_mem_supported = true; > + /* platform instead of architectural choice */ > + mc->cpu_cluster_has_numa_boundary = true; > mc->default_ram_id = "riscv_virt_board.ram"; > assert(!mc->get_hotplug_handler); > mc->get_hotplug_handler = virt_machine_get_hotplug_handler;
diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index cc3f6dac17..b09b993634 100644 --- a/hw/riscv/spike.c +++ b/hw/riscv/spike.c @@ -357,6 +357,8 @@ static void spike_machine_class_init(ObjectClass *oc, void *data) mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; mc->get_default_cpu_node_id = riscv_numa_get_default_cpu_node_id; mc->numa_mem_supported = true; + /* platform instead of architectural choice */ + mc->cpu_cluster_has_numa_boundary = true; mc->default_ram_id = "riscv.spike.ram"; } diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index b81081c70b..e5bb168169 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1636,6 +1636,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; mc->get_default_cpu_node_id = riscv_numa_get_default_cpu_node_id; mc->numa_mem_supported = true; + /* platform instead of architectural choice */ + mc->cpu_cluster_has_numa_boundary = true; mc->default_ram_id = "riscv_virt_board.ram"; assert(!mc->get_hotplug_handler); mc->get_hotplug_handler = virt_machine_get_hotplug_handler;
There are two RISCV machines where NUMA is aware: 'virt' and 'spike'. Both of them are required to follow cluster-NUMA-node boundary. To enable the validation to warn about the irregular configuration where multiple CPUs in one cluster has been associated with multiple NUMA nodes. Signed-off-by: Gavin Shan <gshan@redhat.com> --- hw/riscv/spike.c | 2 ++ hw/riscv/virt.c | 2 ++ 2 files changed, 4 insertions(+)