Message ID | 20230303083740.12817-1-palmer@rivosinc.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, 3 Mar 2023 at 08:41, Palmer Dabbelt <palmer@rivosinc.com> wrote: > > merged tag 'buildsys-qom-qdev-ui-20230227' > The following changes since commit 627634031092e1514f363fd8659a579398de0f0e: > > Merge tag 'buildsys-qom-qdev-ui-20230227' of https://github.com/philmd/qemu into staging (2023-02-28 15:09:18 +0000) > > are available in the Git repository at: > > https://gitlab.com/palmer-dabbelt/qemu.git tags/pull-riscv-to-apply-20230303 > > for you to fetch changes up to 37151032989ecf6e7ce8b65bc7bcb400d0318b2c: > > Merge patch series "target/riscv: some vector_helper.c cleanups" (2023-03-01 18:09:48 -0800) > > ---------------------------------------------------------------- > Fifth RISC-V PR for QEMU 8.0 > > * Experimantal support for writable misa. > * Support for Svadu extension. > * Support for the Zicond extension. > * Fixes to gdbstub, CSR accesses, dependencies between the various > floating-point exceptions, and XTheadMemPair. > * Many cleanups. > > ---------------------------------------------------------------- > There's a lot of cleanups here, a handful of which ended up stepping on > each other and were necessary for various features. I tried to keep > each individual patch set intact, but that led to some merge conflicts > and a bit of a clunky history -- I'm not sure what the right answer is > there, happy to re-spin this to be more linear if that's problem for > folks. It looks like in this case you got lucky, but in general I don't recommend including merge commits in your pull requests, rather than fixing up patches by rebasing them. If I find that a pull request has merge conflicts when I try to merge it, I'm going to kick it back to you to rebase, and then you need to rebase and fix up the commits in it anyway... thanks -- PMM
On Fri, 3 Mar 2023 at 08:41, Palmer Dabbelt <palmer@rivosinc.com> wrote: > > merged tag 'buildsys-qom-qdev-ui-20230227' > The following changes since commit 627634031092e1514f363fd8659a579398de0f0e: > > Merge tag 'buildsys-qom-qdev-ui-20230227' of https://github.com/philmd/qemu into staging (2023-02-28 15:09:18 +0000) > > are available in the Git repository at: > > https://gitlab.com/palmer-dabbelt/qemu.git tags/pull-riscv-to-apply-20230303 > > for you to fetch changes up to 37151032989ecf6e7ce8b65bc7bcb400d0318b2c: > > Merge patch series "target/riscv: some vector_helper.c cleanups" (2023-03-01 18:09:48 -0800) > > ---------------------------------------------------------------- > Fifth RISC-V PR for QEMU 8.0 > > * Experimantal support for writable misa. > * Support for Svadu extension. > * Support for the Zicond extension. > * Fixes to gdbstub, CSR accesses, dependencies between the various > floating-point exceptions, and XTheadMemPair. > * Many cleanups. > > ---------------------------------------------------------------- > There's a lot of cleanups here, a handful of which ended up stepping on > each other and were necessary for various features. I tried to keep > each individual patch set intact, but that led to some merge conflicts > and a bit of a clunky history -- I'm not sure what the right answer is > there, happy to re-spin this to be more linear if that's problem for > folks. > > Unfortunately the OpenSBI bump is still failing CI, it turns out I > missed the second stage. I was intending on having a sixth PR anyway as > I'd really like to get the ACPI patches in for 8.0 so we can start > testing everywhere else. There's also a patch set from Daniel that's > ready to go but depends on some recently merged TCG patches, so I > figured it'd be better to just send what's ready now rather than trying > to make the history more complicated. > > This all passes my local tests ("make check" and a bunch of Linux > configs), but "push-ci-now" is still tripping up on OpenSBI as that's > due to some network resources changing. With any luck I'll have some > time to sort things out this weekend (though always happy to have some > help if anyone wants to throw in some time). > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0 for any user-visible changes. -- PMM