Message ID | 20230310174223.944843-7-iii@linux.ibm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | target/s390x: Handle unaligned accesses | expand |
On 3/10/23 09:42, Ilya Leoshkevich wrote: > Use MO_ALIGN_4 and let do_unaligned_access() generate a specification > exception. > > Reported-by: Nina Schoetterl-Glausch<nsg@linux.ibm.com> > Suggested-by: Nina Schoetterl-Glausch<nsg@linux.ibm.com> > Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com> > --- > target/s390x/tcg/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) MO_ALIGN again, but otherwise Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 6ceb14de92f..d5e64d168f2 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -5999,7 +5999,8 @@ static void in2_mri2_16u(DisasContext *s, DisasOps *o) static void in2_mri2_32s(DisasContext *s, DisasOps *o) { o->in2 = tcg_temp_new_i64(); - tcg_gen_qemu_ld32s(o->in2, gen_ri2(s), get_mem_index(s)); + tcg_gen_qemu_ld_tl(o->in2, gen_ri2(s), get_mem_index(s), + MO_TESL | MO_ALIGN_4); } #define SPEC_in2_mri2_32s 0
Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com> Suggested-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)