Message ID | 20230327173058.199027-1-casantos@redhat.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Series | [V2] tracing: install trace events file only if necessary | expand |
On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote: > From: Carlos Santos <casantos@redhat.com> > > It is not useful when configuring with --enable-trace-backends=nop. > > Signed-off-by: Carlos Santos <casantos@redhat.com> > --- Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On Mon, Mar 27, 2023 at 2:59 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote: > > From: Carlos Santos <casantos@redhat.com> > > > > It is not useful when configuring with --enable-trace-backends=nop. > > > > Signed-off-by: Carlos Santos <casantos@redhat.com> > > --- > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > I updated the patch to fix the array comparison and add a missing comma.
diff --git a/trace/meson.build b/trace/meson.build index 8e80be895c..3d96b4eea0 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', input: trace_events_files, command: [ 'cat', '@INPUT@' ], capture: true, - install: true, + install: get_option('trace_backends') != 'nop' install_dir: qemu_datadir) if 'ust' in get_option('trace_backends')