| Message ID | 20230411101709.445259-1-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | roms: add back edk2-basetools target | expand |
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <kraxel@redhat.com>:
> + python3 edk2-build.py --config edk2-build.config -m none
Is '-m none' correct?
I think previously the result was just a native build.
Now that introduced .config attempts cross builds.
Maybe that detail must be mentioned in the release notes, and the build requirements.
Olaf
On Tue, Apr 11, 2023 at 12:26:47PM +0200, Olaf Hering wrote: > Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <kraxel@redhat.com>: > > > + python3 edk2-build.py --config edk2-build.config -m none > > Is '-m none' correct? Yes. BaseTools are built no matter what because any edk2 stuff depends on them. take care, Gerd
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <kraxel@redhat.com>: > +++ b/roms/Makefile > +edk2-basetools: > + python3 edk2-build.py --config edk2-build.config -m none I think that needs to be $(PYTHON), because plain 'python3' may not be the required python version. In addition, a global EDK2_OPTIONS may allow to pass arbitrary options to their build wrapper, like -j1. Olaf
diff --git a/roms/Makefile b/roms/Makefile index 6859685290bf..73127445a515 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -153,6 +153,9 @@ efi: rm -f ../pc-bios/edk2-*.fd.bz2 bzip2 --verbose ../pc-bios/edk2-*.fd +edk2-basetools: + python3 edk2-build.py --config edk2-build.config -m none + opensbi32-generic: $(MAKE) -C opensbi \ CROSS_COMPILE=$(riscv32_cross_prefix) \
The efi nic boot rom builds depend on this, they need the EfiRom utility from edk2 BaseTools. Fixes: 22e11539e167 ("edk2: replace build scripts") Reported-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+)