diff mbox series

[01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER

Message ID 20230426004057.1318768-1-tsimpson@quicinc.com (mailing list archive)
State New, archived
Headers show
Series Hexagon (target/hexagon) short-circuit and move to DisasContext | expand

Commit Message

Taylor Simpson April 26, 2023, 12:40 a.m. UTC
Enable conditional compilation depending on whether idef-parser
is configured

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson April 26, 2023, 5:32 p.m. UTC | #1
On 4/26/23 01:40, Taylor Simpson wrote:
> Enable conditional compilation depending on whether idef-parser
> is configured
> 
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)

Are you not at the point where you want this unconditionally?
How long do you intend to keep this optional?


r~
Taylor Simpson April 26, 2023, 5:34 p.m. UTC | #2
> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Wednesday, April 26, 2023 12:32 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@linaro.org; ale@rev.ng; anjo@rev.ng; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; pbonzini@redhat.com;
> marcandre.lureau@redhat.com; berrange@redhat.com; thuth@redhat.com
> Subject: Re: [PATCH 01/21] meson.build Add
> CONFIG_HEXAGON_IDEF_PARSER
> 
> On 4/26/23 01:40, Taylor Simpson wrote:
> > Enable conditional compilation depending on whether idef-parser is
> > configured
> >
> > Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> > ---
> >   meson.build | 1 +
> >   1 file changed, 1 insertion(+)
> 
> Are you not at the point where you want this unconditionally?
> How long do you intend to keep this optional?

The default is ON, but we want to keep the OFF option working.

Thanks,
Taylor
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index c44d05a13f..d4e438b033 100644
--- a/meson.build
+++ b/meson.build
@@ -1859,6 +1859,7 @@  endif
 config_host_data.set('CONFIG_GTK', gtk.found())
 config_host_data.set('CONFIG_VTE', vte.found())
 config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)
+config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))
 config_host_data.set('CONFIG_LIBATTR', have_old_libattr)
 config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())
 config_host_data.set('CONFIG_EBPF', libbpf.found())