From patchwork Thu Apr 27 21:10:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Bulekov X-Patchwork-Id: 13225762 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E04AC77B7C for ; Thu, 27 Apr 2023 21:11:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ps8tA-0005sq-DV; Thu, 27 Apr 2023 17:10:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps8t6-0005rx-0t for qemu-devel@nongnu.org; Thu, 27 Apr 2023 17:10:49 -0400 Received: from esa8.hc2706-39.iphmx.com ([216.71.140.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps8t3-0005MH-82 for qemu-devel@nongnu.org; Thu, 27 Apr 2023 17:10:47 -0400 X-IronPort-RemoteIP: 209.85.222.199 X-IronPort-MID: 273267400 X-IronPort-Reputation: None X-IronPort-Listener: OutgoingMail X-IronPort-SenderGroup: RELAY_GSUITE X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+IGXKaA07k9pqxVW/5fhw5YqxClBgxIJ4kV8jS/XYbTApGwrgTIDz WEeXT+DPfmIZ2X2fdAlPoWx/U8G78DSy9Y3TANkpHpgcSl2pJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH2dOCn9SImvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0ilaYDkpOs/jY8E8146yp0N8llgdWic5j7Qe2e0Y9Ucp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VTKlLgFVHmZkl+AsBOtiN/Shkaic7XAha9hXB/0F1ll/gpo DlEWAfZpQ0BZ8Ugk8xEO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPGyqpEF1smALEkubl7XmJWr sJHGTskO0Xra+KemNpXS8Fpj8UnadDoZcYR4yAxiz7eCvkiTNbIRKCiCd1whm9hwJATW6yEP YxAOGsHgBfoOnWjPn8eDII4kP2AjGS5fjFFwL6QjfBouDKNk1ApiNABNvLqIPGTdOkSwX+U+ ELFxELhHA0cOe6AnG/tHnWEw7WncTnAcJsfEaD9+vN0jVm7wGsVBxsLE1yhrpGEZlWWXtteL wkN+XNro/FjpQqkSd7yWxD+q3mB1vIBZ+dt/yQBwFnl4sLpD8yxXQDokhYphAQaifIL IronPort-HdrOrdr: A9a23:tpe5R66AU/ywPhytLAPXwPHXdLJyesId70hD6qkRc20tTiX8ra qTdZsgtSMc5AxhP03Is+rwW5VoOEmsl6KdgrN+AV7BZniChILAFugLhrcKqAeQfxEWmNQts5 uIsJITNDQzNzVHZArBjzVQ2uxA/OW6 X-Talos-CUID: 9a23:J+VyKWnx4lwOShyXdceA2zgtfnrXOVfUk13LOV+FNVoqF7HKSkfLxvxVmOM7zg== X-Talos-MUID: 9a23:q2HQIgrTUrfcNGGofpoezw44Gd5Zz+PxMUxTsZY9ndGaKSp9CSjI2Q== Received: from mail-qk1-f199.google.com ([209.85.222.199]) by ob1.hc2706-39.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Apr 2023 17:10:43 -0400 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-74e0cfab3f0so1383337785a.1 for ; Thu, 27 Apr 2023 14:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bu.edu; s=s1gsbu; t=1682629842; x=1685221842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3SdAMrXHXFKpIl5axn2Wa+vv4dRDlBMdBU9qEifc6x0=; b=KW7CV0J6EY0fDwThGtGw2mV/XIr2QVr9ZzmmCxQL3KD5G23HIbJP/Ts25JkCfWJ+RC IxqH5DOE5TQpIU5qq1u4hOuL3nbZrAkljXBE8lakBfKn7bTXfWNyNOCZz14xAvGyp0+S 2hGWcspqZ4+8E2sXL+sv2K0mdNtZj2GbZF9R1aa0i6SV9V89V7VGCreAM1BlXZ8ybVrV rqHkU/HW4W5kRTo+9zfKTibYMRJ9flsws+Snd0flNLR/81a6s0K1F6xk6k+oQ4LOPkO9 LYW0Q/4CCusiAk91x76HiHDTm7kXIVoCebsvov/G4taQnZfTgFuXGz/FGKq8VHbM4P9n agQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682629842; x=1685221842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3SdAMrXHXFKpIl5axn2Wa+vv4dRDlBMdBU9qEifc6x0=; b=cxMteY2wlHYSqj5WPa+TnQcxF9K44l6TrhekrJHif6A6d0hL11FeXK2frH6bcPi0Uk 1IWQE+xitGhHt+UrCXlzO0fxn/raDFJ4RZGghYS1cNGuxb1jHesWwFpCncFb42Y7hu6L Qcd7ynkWDwo7Wq1yY3LhmcAtFfC632qr/H9QMyww5Z2uli4xjJBIJxiF26aItcK5+udW riuyKvZ39Sl6/d9o0hPrkYlIsKMnxjDNCra+STHunq3DE/5E75brKZExlCQMtktTJnI+ l/0ihN7dLfWbQcP24UhNIUclfjqhBdOZ1h4YsjaCl0PdgpyyuB/OgQkICWnJcLHu9Rie FJtQ== X-Gm-Message-State: AC+VfDz2r+E1oowp2QLPUVlejiEKprhnO2wDbv0zwSiPwX6+DgnU4gRZ EPU2D4lAo4j4Q7busM7lY2x/BfuZ+Fabr+pdJ50bxwD9tAqSilSoeNWfIYXB2ZUQPan9PjhBKn1 osevOOpvycpDPjjSNSVH+dT/13UoSsZ8vI4aoK2LYPbg= X-Received: by 2002:a05:6214:20ee:b0:614:da60:f45d with SMTP id 14-20020a05621420ee00b00614da60f45dmr4902469qvk.30.1682629842287; Thu, 27 Apr 2023 14:10:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6B2366U41LLQszN6ihcZBrJk8YDRrKzcE3mBVfX6MFBk6kfHQJtYnCxk0tCNi7X4uqKewdLA== X-Received: by 2002:a05:6214:20ee:b0:614:da60:f45d with SMTP id 14-20020a05621420ee00b00614da60f45dmr4902422qvk.30.1682629842058; Thu, 27 Apr 2023 14:10:42 -0700 (PDT) Received: from mozz.bu.edu (mozz.bu.edu. [128.197.127.33]) by smtp.gmail.com with ESMTPSA id z30-20020a0ca95e000000b005ef61084fddsm5909401qva.131.2023.04.27.14.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 14:10:41 -0700 (PDT) From: Alexander Bulekov To: qemu-devel@nongnu.org Cc: Alexander Bulekov , Stefan Hajnoczi , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Mauro Matteo Cascella , Peter Xu , Jason Wang , David Hildenbrand , Gerd Hoffmann , Thomas Huth , Laurent Vivier , Bandan Das , "Edgar E . Iglesias" , Darren Kenny , Bin Meng , Paolo Bonzini , "Michael S . Tsirkin" , Marcel Apfelbaum , =?utf-8?q?Daniel_P_=2E_Berra?= =?utf-8?q?ng=C3=A9?= , Eduardo Habkost , Jon Maloy , Siqi Chen , Michael Tokarev , Fiona Ebner , Fam Zheng Subject: [PATCH v10 5/8] lsi53c895a: disable reentrancy detection for script RAM Date: Thu, 27 Apr 2023 17:10:10 -0400 Message-Id: <20230427211013.2994127-6-alxndr@bu.edu> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230427211013.2994127-1-alxndr@bu.edu> References: <20230427211013.2994127-1-alxndr@bu.edu> MIME-Version: 1.0 X-CES-GSUITE_AUTH: bf3aNvsZpxl8 Received-SPF: pass client-ip=216.71.140.196; envelope-from=alxndr@bu.edu; helo=esa8.hc2706-39.iphmx.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.266, HK_RANDOM_FROM=0.999, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org As the code is designed to use the memory APIs to access the script ram, disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion. In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion. Reported-by: Fiona Ebner Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Reviewed-by: Darren Kenny --- hw/scsi/lsi53c895a.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index af93557a9a..db27872963 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -2302,6 +2302,12 @@ static void lsi_scsi_realize(PCIDevice *dev, Error **errp) memory_region_init_io(&s->io_io, OBJECT(s), &lsi_io_ops, s, "lsi-io", 256); + /* + * Since we use the address-space API to interact with ram_io, disable the + * re-entrancy guard. + */ + s->ram_io.disable_reentrancy_guard = true; + address_space_init(&s->pci_io_as, pci_address_space_io(dev), "lsi-pci-io"); qdev_init_gpio_out(d, &s->ext_irq, 1);