diff mbox series

[05/17] Revert "qapi: BlockExportRemoveMode: move comments to TODO"

Message ID 20230428105429.1687850-6-armbru@redhat.com (mailing list archive)
State New, archived
Headers show
Series qapi: Reformat doc comments | expand

Commit Message

Markus Armbruster April 28, 2023, 10:54 a.m. UTC 
This reverts commit 97cd74f77231f3897838f8db32b659d94803e01f.

The next commit will hide TODO: sections.  See there for rationale.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/block-export.json | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Juan Quintela April 28, 2023, 5:57 p.m. UTC | #1 
Markus Armbruster <armbru@redhat.com> wrote:
> This reverts commit 97cd74f77231f3897838f8db32b659d94803e01f.
>
> The next commit will hide TODO: sections.  See there for rationale.

Reviewing with forward pointers has its own challenges O:-)

> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>
diff mbox series

Patch

diff --git a/qapi/block-export.json b/qapi/block-export.json
index 3be3de357f..3ec8ad0ce7 100644
--- a/qapi/block-export.json
+++ b/qapi/block-export.json
@@ -249,13 +249,13 @@ 
 #
 # @hard: Drop all connections immediately and remove export.
 #
-# TODO: Potential additional modes to be added in the future:
+# Potential additional modes to be added in the future:
 #
-#       hide: Just hide export from new clients, leave existing connections as is.
-#       Remove export after all clients are disconnected.
+# hide: Just hide export from new clients, leave existing connections as is.
+# Remove export after all clients are disconnected.
 #
-#       soft: Hide export from new clients, answer with ESHUTDOWN for all further
-#       requests from existing clients.
+# soft: Hide export from new clients, answer with ESHUTDOWN for all further
+# requests from existing clients.
 #
 # Since: 2.12
 ##