| Message ID | 20230510203601.418015-7-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: Honour graph read lock even in the main thread | expand |
On Wed, May 10, 2023 at 10:35:59PM +0200, Kevin Wolf wrote: > > bdrv_unref() is a no_coroutine_fn, so calling it from coroutine context > is invalid. Use bdrv_co_unref() instead. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > tests/unit/test-bdrv-drain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/tests/unit/test-bdrv-drain.c b/tests/unit/test-bdrv-drain.c > index ae4299ccfa..08bb0f9984 100644 > --- a/tests/unit/test-bdrv-drain.c > +++ b/tests/unit/test-bdrv-drain.c > @@ -1019,7 +1019,7 @@ static void coroutine_fn test_co_delete_by_drain(void *opaque) > g_assert_cmpint(bs->refcnt, ==, 1); > > if (!dbdd->detach_instead_of_delete) { > - blk_unref(blk); > + blk_co_unref(blk); > } else { > BdrvChild *c, *next_c; > QLIST_FOREACH_SAFE(c, &bs->children, next, next_c) { > -- > 2.40.1 > >
diff --git a/tests/unit/test-bdrv-drain.c b/tests/unit/test-bdrv-drain.c index ae4299ccfa..08bb0f9984 100644 --- a/tests/unit/test-bdrv-drain.c +++ b/tests/unit/test-bdrv-drain.c @@ -1019,7 +1019,7 @@ static void coroutine_fn test_co_delete_by_drain(void *opaque) g_assert_cmpint(bs->refcnt, ==, 1); if (!dbdd->detach_instead_of_delete) { - blk_unref(blk); + blk_co_unref(blk); } else { BdrvChild *c, *next_c; QLIST_FOREACH_SAFE(c, &bs->children, next, next_c) {
bdrv_unref() is a no_coroutine_fn, so calling it from coroutine context is invalid. Use bdrv_co_unref() instead. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- tests/unit/test-bdrv-drain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)