| Message ID | 20230523163600.83391-8-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/virtio: Build various target-agnostic objects just once | expand |
On 5/23/23 09:35, Philippe Mathieu-Daudé wrote: > Instead of having "virtio/virtio-bus.h" implicitly included, > explicit it, to avoid when rearranging headers: > > hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’: > hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’? > 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > | ^~~~~~~~~~~~~~ > | VirtioDeviceClass > hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’? [-Werror=implicit-function-declaration] > 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); > | ^~~~~~~~~~~~~~~~~~~~ > | VIRTIO_DEVICE_CLASS > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/virtio/vhost-vsock-common.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: > Instead of having "virtio/virtio-bus.h" implicitly included, > explicit it, to avoid when rearranging headers: s/explicit it/explicitly include it/ ? With that change: Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/virtio/vhost-vsock-common.c b/hw/virtio/vhost-vsock-common.c index d2b5519d5a..e89af9b329 100644 --- a/hw/virtio/vhost-vsock-common.c +++ b/hw/virtio/vhost-vsock-common.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "standard-headers/linux/virtio_vsock.h" #include "qapi/error.h" +#include "hw/virtio/virtio-bus.h" #include "hw/virtio/virtio-access.h" #include "qemu/error-report.h" #include "hw/qdev-properties.h"
Instead of having "virtio/virtio-bus.h" implicitly included, explicit it, to avoid when rearranging headers: hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’: hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’? 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); | ^~~~~~~~~~~~~~ | VirtioDeviceClass hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’? [-Werror=implicit-function-declaration] 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); | ^~~~~~~~~~~~~~~~~~~~ | VIRTIO_DEVICE_CLASS Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/virtio/vhost-vsock-common.c | 1 + 1 file changed, 1 insertion(+)