| Message ID | 20230526181240.1425579-3-iii@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix Fedora 38 Clang on s390x | expand |
On 5/26/23 11:12, Ilya Leoshkevich wrote: > Add a test to prevent regressions. > > Cc:qemu-stable@nongnu.org > Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com> > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/lcbb.c | 51 +++++++++++++++++++++++++++++++++ > 2 files changed, 52 insertions(+) > create mode 100644 tests/tcg/s390x/lcbb.c Acked-by: Richard Henderson <richard.henderson@linaro.org> r~
On 26.05.23 20:12, Ilya Leoshkevich wrote: > Add a test to prevent regressions. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/lcbb.c | 51 +++++++++++++++++++++++++++++++++ > 2 files changed, 52 insertions(+) > create mode 100644 tests/tcg/s390x/lcbb.c > > diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target > index 73f7cb828e3..c48de439625 100644 > --- a/tests/tcg/s390x/Makefile.target > +++ b/tests/tcg/s390x/Makefile.target > @@ -47,6 +47,7 @@ $(PGM_SPECIFICATION_TESTS): LDFLAGS+=pgm-specification-user.o > TESTS += $(PGM_SPECIFICATION_TESTS) > > Z13_TESTS=vistr > +Z13_TESTS+=lcbb > $(Z13_TESTS): CFLAGS+=-march=z13 -O2 > TESTS+=$(Z13_TESTS) > > diff --git a/tests/tcg/s390x/lcbb.c b/tests/tcg/s390x/lcbb.c > new file mode 100644 > index 00000000000..8d368e0998d > --- /dev/null > +++ b/tests/tcg/s390x/lcbb.c > @@ -0,0 +1,51 @@ > +/* > + * Test the LCBB instruction. > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + */ > +#include <assert.h> > +#include <stdlib.h> > + > +static inline __attribute__((__always_inline__)) void > +lcbb(long *r1, void *dxb2, int m3, int *cc) > +{ > + asm("lcbb %[r1],%[dxb2],%[m3]\n" > + "ipm %[cc]" > + : [r1] "+r" (*r1), [cc] "=r" (*cc) > + : [dxb2] "R" (*(char *)dxb2), [m3] "i" (m3) > + : "cc"); > + *cc = (*cc >> 28) & 3; > +} > + > +static char buf[0x1000] __attribute__((aligned(0x1000))); > + > +static inline __attribute__((__always_inline__)) void > +test_lcbb(void *p, int m3, int exp_r1, int exp_cc) > +{ > + long r1 = 0xfedcba9876543210; > + int cc; > + > + lcbb(&r1, p, m3, &cc); > + assert(r1 == (0xfedcba9800000000 | exp_r1)); > + assert(cc == exp_cc); > +} > + > +int main(void) > +{ > + test_lcbb(&buf[0], 0, 16, 0); > + test_lcbb(&buf[63], 0, 1, 3); > + test_lcbb(&buf[0], 1, 16, 0); > + test_lcbb(&buf[127], 1, 1, 3); > + test_lcbb(&buf[0], 2, 16, 0); > + test_lcbb(&buf[255], 2, 1, 3); > + test_lcbb(&buf[0], 3, 16, 0); > + test_lcbb(&buf[511], 3, 1, 3); > + test_lcbb(&buf[0], 4, 16, 0); > + test_lcbb(&buf[1023], 4, 1, 3); > + test_lcbb(&buf[0], 5, 16, 0); > + test_lcbb(&buf[2047], 5, 1, 3); > + test_lcbb(&buf[0], 6, 16, 0); > + test_lcbb(&buf[4095], 6, 1, 3); > + > + return EXIT_SUCCESS; > +} Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target index 73f7cb828e3..c48de439625 100644 --- a/tests/tcg/s390x/Makefile.target +++ b/tests/tcg/s390x/Makefile.target @@ -47,6 +47,7 @@ $(PGM_SPECIFICATION_TESTS): LDFLAGS+=pgm-specification-user.o TESTS += $(PGM_SPECIFICATION_TESTS) Z13_TESTS=vistr +Z13_TESTS+=lcbb $(Z13_TESTS): CFLAGS+=-march=z13 -O2 TESTS+=$(Z13_TESTS) diff --git a/tests/tcg/s390x/lcbb.c b/tests/tcg/s390x/lcbb.c new file mode 100644 index 00000000000..8d368e0998d --- /dev/null +++ b/tests/tcg/s390x/lcbb.c @@ -0,0 +1,51 @@ +/* + * Test the LCBB instruction. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#include <assert.h> +#include <stdlib.h> + +static inline __attribute__((__always_inline__)) void +lcbb(long *r1, void *dxb2, int m3, int *cc) +{ + asm("lcbb %[r1],%[dxb2],%[m3]\n" + "ipm %[cc]" + : [r1] "+r" (*r1), [cc] "=r" (*cc) + : [dxb2] "R" (*(char *)dxb2), [m3] "i" (m3) + : "cc"); + *cc = (*cc >> 28) & 3; +} + +static char buf[0x1000] __attribute__((aligned(0x1000))); + +static inline __attribute__((__always_inline__)) void +test_lcbb(void *p, int m3, int exp_r1, int exp_cc) +{ + long r1 = 0xfedcba9876543210; + int cc; + + lcbb(&r1, p, m3, &cc); + assert(r1 == (0xfedcba9800000000 | exp_r1)); + assert(cc == exp_cc); +} + +int main(void) +{ + test_lcbb(&buf[0], 0, 16, 0); + test_lcbb(&buf[63], 0, 1, 3); + test_lcbb(&buf[0], 1, 16, 0); + test_lcbb(&buf[127], 1, 1, 3); + test_lcbb(&buf[0], 2, 16, 0); + test_lcbb(&buf[255], 2, 1, 3); + test_lcbb(&buf[0], 3, 16, 0); + test_lcbb(&buf[511], 3, 1, 3); + test_lcbb(&buf[0], 4, 16, 0); + test_lcbb(&buf[1023], 4, 1, 3); + test_lcbb(&buf[0], 5, 16, 0); + test_lcbb(&buf[2047], 5, 1, 3); + test_lcbb(&buf[0], 6, 16, 0); + test_lcbb(&buf[4095], 6, 1, 3); + + return EXIT_SUCCESS; +}
Add a test to prevent regressions. Cc: qemu-stable@nongnu.org Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/lcbb.c | 51 +++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 tests/tcg/s390x/lcbb.c