diff mbox series

[2/5] gitlab-ci: Reference rules instead of extends

Message ID 20230531150824.32349-3-cconte@redhat.com (mailing list archive)
State New, archived
Headers show
Series [1/5] gitlab-ci: Remove unused Python package | expand

Commit Message

Camilla Conte May 31, 2023, 3:08 p.m. UTC
This allows for the jobs to extend different templates while
having a shared template for rules.

Docs:
https://docs.gitlab.com/ee/ci/jobs/job_control.html#reuse-rules-in-different-jobs
Signed-off-by: Camilla Conte <cconte@redhat.com>
---
 .gitlab-ci.d/opensbi.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Daniel P. Berrangé May 31, 2023, 3:14 p.m. UTC | #1
On Wed, May 31, 2023 at 04:08:21PM +0100, Camilla Conte wrote:
> This allows for the jobs to extend different templates while
> having a shared template for rules.
> 
> Docs:
> https://docs.gitlab.com/ee/ci/jobs/job_control.html#reuse-rules-in-different-jobs
> Signed-off-by: Camilla Conte <cconte@redhat.com>
> ---
>  .gitlab-ci.d/opensbi.yml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
diff mbox series

Patch

diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index 2e9d51764e..d0221632f6 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -40,7 +40,8 @@ 
       when: on_success
 
 docker-opensbi:
-  extends: .opensbi_job_rules
+  rules:
+    - !reference [.opensbi_job_rules, rules]
   stage: containers
   image: docker:stable
   services:
@@ -59,7 +60,8 @@  docker-opensbi:
     - docker push $IMAGE_TAG
 
 build-opensbi:
-  extends: .opensbi_job_rules
+  rules:
+    - !reference [.opensbi_job_rules, rules]
   stage: build
   needs: ['docker-opensbi']
   artifacts: