| Message ID | 20230611103412.12109-5-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Q35 and I440FX host bridge QOM cleanup | expand |
On Sun, 11 Jun 2023 12:34:01 +0200 Bernhard Beschow <shentey@gmail.com> wrote: > Introduce a macro to avoid copy and pasting strings which can easily > cause typos. > > Suggested-by: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > include/hw/pci/pci_host.h | 2 ++ > hw/pci/pci_host.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h > index c6f4eb4585..e52d8ec2cd 100644 > --- a/include/hw/pci/pci_host.h > +++ b/include/hw/pci/pci_host.h > @@ -31,6 +31,8 @@ > #include "hw/sysbus.h" > #include "qom/object.h" > > +#define PCI_HOST_BYPASS_IOMMU "bypass-iommu" > + > #define TYPE_PCI_HOST_BRIDGE "pci-host-bridge" > OBJECT_DECLARE_TYPE(PCIHostState, PCIHostBridgeClass, PCI_HOST_BRIDGE) > > diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c > index dfd185bbb4..7af8afdcbe 100644 > --- a/hw/pci/pci_host.c > +++ b/hw/pci/pci_host.c > @@ -232,7 +232,7 @@ const VMStateDescription vmstate_pcihost = { > static Property pci_host_properties_common[] = { > DEFINE_PROP_BOOL("x-config-reg-migration-enabled", PCIHostState, > mig_enabled, true), > - DEFINE_PROP_BOOL("bypass-iommu", PCIHostState, bypass_iommu, false), > + DEFINE_PROP_BOOL(PCI_HOST_BYPASS_IOMMU, PCIHostState, bypass_iommu, false), > DEFINE_PROP_END_OF_LIST(), > }; >
diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h index c6f4eb4585..e52d8ec2cd 100644 --- a/include/hw/pci/pci_host.h +++ b/include/hw/pci/pci_host.h @@ -31,6 +31,8 @@ #include "hw/sysbus.h" #include "qom/object.h" +#define PCI_HOST_BYPASS_IOMMU "bypass-iommu" + #define TYPE_PCI_HOST_BRIDGE "pci-host-bridge" OBJECT_DECLARE_TYPE(PCIHostState, PCIHostBridgeClass, PCI_HOST_BRIDGE) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index dfd185bbb4..7af8afdcbe 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -232,7 +232,7 @@ const VMStateDescription vmstate_pcihost = { static Property pci_host_properties_common[] = { DEFINE_PROP_BOOL("x-config-reg-migration-enabled", PCIHostState, mig_enabled, true), - DEFINE_PROP_BOOL("bypass-iommu", PCIHostState, bypass_iommu, false), + DEFINE_PROP_BOOL(PCI_HOST_BYPASS_IOMMU, PCIHostState, bypass_iommu, false), DEFINE_PROP_END_OF_LIST(), };
Introduce a macro to avoid copy and pasting strings which can easily cause typos. Suggested-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- include/hw/pci/pci_host.h | 2 ++ hw/pci/pci_host.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)