| Message ID | 20230629084042.86502-3-zhenzhong.duan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | VFIO migration related refactor and bug fix | expand |
On 29/06/2023 09:40, Zhenzhong Duan wrote: > When vfio_realize fails, the mmap_timer used for INTx optimization > isn't freed. As this timer isn't activated yet, the potential impact > is just a piece of leaked memory. > > Fixes: ea486926b07d ("vfio-pci: Update slow path INTx algorithm timer related") > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Reviewed-by: Joao Martins <joao.m.martins@oracle.com> > --- > hw/vfio/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 48df517f79ee..ab6645ba60af 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3224,6 +3224,9 @@ out_deregister: > if (vdev->irqchip_change_notifier.notify) { > kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier); > } > + if (vdev->intx.mmap_timer) { > + timer_free(vdev->intx.mmap_timer); > + } > out_teardown: > vfio_teardown_msi(vdev); > vfio_bars_exit(vdev);
On 6/29/23 10:40, Zhenzhong Duan wrote: > When vfio_realize fails, the mmap_timer used for INTx optimization > isn't freed. As this timer isn't activated yet, the potential impact > is just a piece of leaked memory. > > Fixes: ea486926b07d ("vfio-pci: Update slow path INTx algorithm timer related") > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > hw/vfio/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 48df517f79ee..ab6645ba60af 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3224,6 +3224,9 @@ out_deregister: > if (vdev->irqchip_change_notifier.notify) { > kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier); > } > + if (vdev->intx.mmap_timer) { > + timer_free(vdev->intx.mmap_timer); > + } > out_teardown: > vfio_teardown_msi(vdev); > vfio_bars_exit(vdev);
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 48df517f79ee..ab6645ba60af 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3224,6 +3224,9 @@ out_deregister: if (vdev->irqchip_change_notifier.notify) { kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier); } + if (vdev->intx.mmap_timer) { + timer_free(vdev->intx.mmap_timer); + } out_teardown: vfio_teardown_msi(vdev); vfio_bars_exit(vdev);
When vfio_realize fails, the mmap_timer used for INTx optimization isn't freed. As this timer isn't activated yet, the potential impact is just a piece of leaked memory. Fixes: ea486926b07d ("vfio-pci: Update slow path INTx algorithm timer related") Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> --- hw/vfio/pci.c | 3 +++ 1 file changed, 3 insertions(+)