| Message ID | 20230717182859.707658-5-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests: enable meson test timeouts to improve debuggability | expand |
On 17/07/2023 20.28, Daniel P. Berrangé wrote: > The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. > Bumping to 5 minutes will give more headroom. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index ecbf515d50..e28f0925e1 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -1,7 +1,7 @@ > slow_qtests = { > 'bios-tables-test' : 120, > 'migration-test' : 300, > - 'npcm7xx_pwm-test': 150, > + 'npcm7xx_pwm-test': 300, > 'qom-test' : 900, > 'test-hmp' : 120, > } Reviewed-by: Thomas Huth <thuth@redhat.com> (we should maybe still have a look at this test later to see why it is so slow, though)
On Wed, 19 Jul 2023 at 14:06, Thomas Huth <thuth@redhat.com> wrote: > > On 17/07/2023 20.28, Daniel P. Berrangé wrote: > > The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. > > Bumping to 5 minutes will give more headroom. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > tests/qtest/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > > index ecbf515d50..e28f0925e1 100644 > > --- a/tests/qtest/meson.build > > +++ b/tests/qtest/meson.build > > @@ -1,7 +1,7 @@ > > slow_qtests = { > > 'bios-tables-test' : 120, > > 'migration-test' : 300, > > - 'npcm7xx_pwm-test': 150, > > + 'npcm7xx_pwm-test': 300, > > 'qom-test' : 900, > > 'test-hmp' : 120, > > } > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > (we should maybe still have a look at this test later to see why it is so > slow, though) It seems to be doing a massively OTT amount of work to test a single device. Nuvoton maintainers, can you have a look at cutting it down, please? thanks -- PMM
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index ecbf515d50..e28f0925e1 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -1,7 +1,7 @@ slow_qtests = { 'bios-tables-test' : 120, 'migration-test' : 300, - 'npcm7xx_pwm-test': 150, + 'npcm7xx_pwm-test': 300, 'qom-test' : 900, 'test-hmp' : 120, }
The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. Bumping to 5 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)