diff mbox series

[v2,1/3] scripts: drop comment about autogenerated CPU API file

Message ID 20230718092631.730255-2-berrange@redhat.com (mailing list archive)
State New, archived
Headers show
Series docs: update x86 CPU model ABI matrix docs | expand

Commit Message

Daniel P. Berrangé July 18, 2023, 9:26 a.m. UTC
The RST doc include can't be made to skip the comment indicating the CPU
CSV file is auto-generated when importing it. This comment line was
previously manually removed from the generated output that was committed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/cpu-x86-uarch-abi.py | 1 -
 1 file changed, 1 deletion(-)

Comments

Zhao Liu Oct. 18, 2023, 2:54 p.m. UTC | #1
On Tue, Jul 18, 2023 at 10:26:29AM +0100, Daniel P. Berrangé wrote:
> Date: Tue, 18 Jul 2023 10:26:29 +0100
> From: "Daniel P. Berrangé" <berrange@redhat.com>
> Subject: [PATCH v2 1/3] scripts: drop comment about autogenerated CPU API
>  file
> 
> The RST doc include can't be made to skip the comment indicating the CPU
> CSV file is auto-generated when importing it. This comment line was
> previously manually removed from the generated output that was committed.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

And tested on master with a fix [1].
If this test case also allows tested-by, then,

Tested-by: Zhao Liu <zhao1.liu@intel.com>

[1]: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg05687.html

> ---
>  scripts/cpu-x86-uarch-abi.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
> index 82ff07582f..b6285247a1 100644
> --- a/scripts/cpu-x86-uarch-abi.py
> +++ b/scripts/cpu-x86-uarch-abi.py
> @@ -179,7 +179,6 @@
>          models[name]["delta"][level] = delta
>  
>  def print_uarch_abi_csv():
> -    print("# Automatically generated from '%s'" % __file__)
>      print("Model,baseline,v2,v3,v4")
>      for name in models.keys():
>          print(name, end="")
> -- 
> 2.41.0
> 
>
diff mbox series

Patch

diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
index 82ff07582f..b6285247a1 100644
--- a/scripts/cpu-x86-uarch-abi.py
+++ b/scripts/cpu-x86-uarch-abi.py
@@ -179,7 +179,6 @@ 
         models[name]["delta"][level] = delta
 
 def print_uarch_abi_csv():
-    print("# Automatically generated from '%s'" % __file__)
     print("Model,baseline,v2,v3,v4")
     for name in models.keys():
         print(name, end="")