| Message ID | 20230801103527.397756-3-zhao1.liu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support smp.clusters for x86 | expand |
Zhao, On 8/1/23 05:35, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > > In fact, this unit tests APIC ID other than CPUID. This is not clear. The tests in test-x86-topo.c actually test the APIC ID combinations. Rename to test-x86-topo.c to make its name more in line with its actual content. > Rename to test-x86-topo.c to make its name more in line with its > actual content. > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > Tested-by: Yongwei Ma <yongwei.ma@intel.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org > Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > Changes since v1: > * Rename test-x86-apicid.c to test-x86-topo.c. (Yanan) > --- > MAINTAINERS | 2 +- > tests/unit/meson.build | 4 ++-- > tests/unit/{test-x86-cpuid.c => test-x86-topo.c} | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > rename tests/unit/{test-x86-cpuid.c => test-x86-topo.c} (99%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 12e59b6b27de..51ba3d593e90 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1719,7 +1719,7 @@ F: include/hw/southbridge/ich9.h > F: include/hw/southbridge/piix.h > F: hw/isa/apm.c > F: include/hw/isa/apm.h > -F: tests/unit/test-x86-cpuid.c > +F: tests/unit/test-x86-topo.c > F: tests/qtest/test-x86-cpuid-compat.c > > PC Chipset > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > index 93977cc32d2b..39b5d0007c69 100644 > --- a/tests/unit/meson.build > +++ b/tests/unit/meson.build > @@ -21,8 +21,8 @@ tests = { > 'test-opts-visitor': [testqapi], > 'test-visitor-serialization': [testqapi], > 'test-bitmap': [], > - # all code tested by test-x86-cpuid is inside topology.h > - 'test-x86-cpuid': [], > + # all code tested by test-x86-topo is inside topology.h > + 'test-x86-topo': [], > 'test-cutils': [], > 'test-div128': [], > 'test-shift128': [], > diff --git a/tests/unit/test-x86-cpuid.c b/tests/unit/test-x86-topo.c > similarity index 99% > rename from tests/unit/test-x86-cpuid.c > rename to tests/unit/test-x86-topo.c > index bfabc0403a1a..2b104f86d7c2 100644 > --- a/tests/unit/test-x86-cpuid.c > +++ b/tests/unit/test-x86-topo.c > @@ -1,5 +1,5 @@ > /* > - * Test code for x86 CPUID and Topology functions > + * Test code for x86 APIC ID and Topology functions > * > * Copyright (c) 2012 Red Hat Inc. > *
Hi Babu, On Tue, Aug 01, 2023 at 06:20:46PM -0500, Moger, Babu wrote: > Date: Tue, 1 Aug 2023 18:20:46 -0500 > From: "Moger, Babu" <babu.moger@amd.com> > Subject: Re: [PATCH v3 02/17] tests: Rename test-x86-cpuid.c to > test-x86-topo.c > > Zhao, > > On 8/1/23 05:35, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > In fact, this unit tests APIC ID other than CPUID. > > This is not clear. > > The tests in test-x86-topo.c actually test the APIC ID combinations. > Rename to test-x86-topo.c to make its name more in line with its actual > content. Thanks, your description is better and clearer! -Zhao > > > Rename to test-x86-topo.c to make its name more in line with its > > actual content. > > > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > > Tested-by: Yongwei Ma <yongwei.ma@intel.com> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > Changes since v1: > > * Rename test-x86-apicid.c to test-x86-topo.c. (Yanan) > > --- > > MAINTAINERS | 2 +- > > tests/unit/meson.build | 4 ++-- > > tests/unit/{test-x86-cpuid.c => test-x86-topo.c} | 2 +- > > 3 files changed, 4 insertions(+), 4 deletions(-) > > rename tests/unit/{test-x86-cpuid.c => test-x86-topo.c} (99%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 12e59b6b27de..51ba3d593e90 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1719,7 +1719,7 @@ F: include/hw/southbridge/ich9.h > > F: include/hw/southbridge/piix.h > > F: hw/isa/apm.c > > F: include/hw/isa/apm.h > > -F: tests/unit/test-x86-cpuid.c > > +F: tests/unit/test-x86-topo.c > > F: tests/qtest/test-x86-cpuid-compat.c > > > > PC Chipset > > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > > index 93977cc32d2b..39b5d0007c69 100644 > > --- a/tests/unit/meson.build > > +++ b/tests/unit/meson.build > > @@ -21,8 +21,8 @@ tests = { > > 'test-opts-visitor': [testqapi], > > 'test-visitor-serialization': [testqapi], > > 'test-bitmap': [], > > - # all code tested by test-x86-cpuid is inside topology.h > > - 'test-x86-cpuid': [], > > + # all code tested by test-x86-topo is inside topology.h > > + 'test-x86-topo': [], > > 'test-cutils': [], > > 'test-div128': [], > > 'test-shift128': [], > > diff --git a/tests/unit/test-x86-cpuid.c b/tests/unit/test-x86-topo.c > > similarity index 99% > > rename from tests/unit/test-x86-cpuid.c > > rename to tests/unit/test-x86-topo.c > > index bfabc0403a1a..2b104f86d7c2 100644 > > --- a/tests/unit/test-x86-cpuid.c > > +++ b/tests/unit/test-x86-topo.c > > @@ -1,5 +1,5 @@ > > /* > > - * Test code for x86 CPUID and Topology functions > > + * Test code for x86 APIC ID and Topology functions > > * > > * Copyright (c) 2012 Red Hat Inc. > > * > > -- > Thanks > Babu Moger
diff --git a/MAINTAINERS b/MAINTAINERS index 12e59b6b27de..51ba3d593e90 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1719,7 +1719,7 @@ F: include/hw/southbridge/ich9.h F: include/hw/southbridge/piix.h F: hw/isa/apm.c F: include/hw/isa/apm.h -F: tests/unit/test-x86-cpuid.c +F: tests/unit/test-x86-topo.c F: tests/qtest/test-x86-cpuid-compat.c PC Chipset diff --git a/tests/unit/meson.build b/tests/unit/meson.build index 93977cc32d2b..39b5d0007c69 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -21,8 +21,8 @@ tests = { 'test-opts-visitor': [testqapi], 'test-visitor-serialization': [testqapi], 'test-bitmap': [], - # all code tested by test-x86-cpuid is inside topology.h - 'test-x86-cpuid': [], + # all code tested by test-x86-topo is inside topology.h + 'test-x86-topo': [], 'test-cutils': [], 'test-div128': [], 'test-shift128': [], diff --git a/tests/unit/test-x86-cpuid.c b/tests/unit/test-x86-topo.c similarity index 99% rename from tests/unit/test-x86-cpuid.c rename to tests/unit/test-x86-topo.c index bfabc0403a1a..2b104f86d7c2 100644 --- a/tests/unit/test-x86-cpuid.c +++ b/tests/unit/test-x86-topo.c @@ -1,5 +1,5 @@ /* - * Test code for x86 CPUID and Topology functions + * Test code for x86 APIC ID and Topology functions * * Copyright (c) 2012 Red Hat Inc. *