From patchwork Tue Aug 15 00:35:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurchetan Singh X-Patchwork-Id: 13353407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CB38C04E69 for ; Tue, 15 Aug 2023 00:36:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVi2D-0004JX-V7; Mon, 14 Aug 2023 20:35:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVi28-0004IN-W5 for qemu-devel@nongnu.org; Mon, 14 Aug 2023 20:35:41 -0400 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVi27-0004rj-AJ for qemu-devel@nongnu.org; Mon, 14 Aug 2023 20:35:40 -0400 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bc9254a1baso4299834a34.2 for ; Mon, 14 Aug 2023 17:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692059737; x=1692664537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CNQKehlburUsg8YOy+BGD8KkdFsC0dbmancllFqkr3I=; b=PzlKiaCaQiZMPrCTypvklrbjEFaLIxHzHhwDWoWkvaPoger3xj1WceDdcPwvzXQjtY VKCWNmooxDwZM8hzKXzDVpNVs0L89ClKGr16ckgv5noTZVHkrtDXWdlHMPe8KcAriPgi DWW5EAJFHWYe6l2Ds901wkLfw3fDxCc1xMu0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692059737; x=1692664537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNQKehlburUsg8YOy+BGD8KkdFsC0dbmancllFqkr3I=; b=KZtb/Cz7WeKsutes3hGZCIN8xRIJ/Cjo0Uz5ObAVAeBzwBGbKiBPBaxWoV+UUe2Ep0 sZ/wcNuCzzyTlJ0XKtjG1Mx4spad3ew5nYMYRyS+wKQlJOj39bl9VdVvAJTFpbrV6E1o Hz6hPHq43Kv+9cYt8Iqlfbx3rBasj407L9wKFuwQM+O9KCVok72+HtQj8GvdNtILBANh I78+7bXmRDSfTNSjggeF91XAONEWPM2sllUHraCYo6nlLvT8vwO5yv85SSPVa69+IUxt 2v1Ol5BXvqtm2z3Vr/i5fwAxuM7HOkDv9ymGffz9lKGig8jS0uZgv27Ea4rUmQHz9P6V tjBg== X-Gm-Message-State: AOJu0YyioKlG39LdD7ZKoajwnc0x0v1lFA7sVPjiLgpVQjCBpSn06Ql3 wsq/dfx+lyx+kerxO8lMo6qGhBDFPybJrdFQupk= X-Google-Smtp-Source: AGHT+IGr2yjaQeVNM0P6QJlLh0azeMq1wsAwwBB353vUmS/DH5RPUrOEz+fqnbSlNYMFHPfdOM5ixw== X-Received: by 2002:a05:6870:424b:b0:1b0:17f2:6518 with SMTP id v11-20020a056870424b00b001b017f26518mr12029432oac.42.1692059737015; Mon, 14 Aug 2023 17:35:37 -0700 (PDT) Received: from gurchetansingh0.mtv.corp.google.com ([2620:15c:a7:2:5e8f:33b0:7163:af34]) by smtp.gmail.com with ESMTPSA id f4-20020a170902e98400b001bdc8a5e96csm2319612plb.169.2023.08.14.17.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 17:35:36 -0700 (PDT) From: Gurchetan Singh To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, akihiko.odaki@gmail.com, dmitry.osipenko@collabora.com, ray.huang@amd.com, alex.bennee@linaro.org, ernunes@redhat.com, hi@alyssa.is, shentey@gmail.com Subject: [PATCH v5 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options Date: Mon, 14 Aug 2023 17:35:22 -0700 Message-Id: <20230815003526.631-6-gurchetansingh@chromium.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230815003526.631-1-gurchetansingh@chromium.org> References: <20230815003526.631-1-gurchetansingh@chromium.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::333; envelope-from=gurchetansingh@chromium.org; helo=mail-ot1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This modifies the common virtio-gpu.h file have the fields and defintions needed by gfxstream/rutabaga, by VirtioGpuRutabaga. The command to run these would be: Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Reviewed-by: Emmanouil Pitsidianakis Tested-by: Emmanouil Pitsidianakis --- -device virtio-vga-rutabaga,capset_names=gfxstream-vulkan:cross-domain, \ wayland_socket_path=/run/user/1000/wayland-0,hostmem=8G \ v1: void *rutabaga --> struct rutabaga *rutabaga (Akihiko) have a separate rutabaga device instead of using GL device (Bernard) v2: VirtioGpuRutabaga --> VirtIOGPURutabaga (Akihiko) move MemoryRegionInfo into VirtIOGPURutabaga (Akihiko) remove 'ctx' field (Akihiko) remove 'rutabaga_active' include/hw/virtio/virtio-gpu.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index 55973e112f..e2a07e68d9 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -38,6 +38,9 @@ OBJECT_DECLARE_SIMPLE_TYPE(VirtIOGPUGL, VIRTIO_GPU_GL) #define TYPE_VHOST_USER_GPU "vhost-user-gpu" OBJECT_DECLARE_SIMPLE_TYPE(VhostUserGPU, VHOST_USER_GPU) +#define TYPE_VIRTIO_GPU_RUTABAGA "virtio-gpu-rutabaga-device" +OBJECT_DECLARE_SIMPLE_TYPE(VirtIOGPURutabaga, VIRTIO_GPU_RUTABAGA) + struct virtio_gpu_simple_resource { uint32_t resource_id; uint32_t width; @@ -94,6 +97,7 @@ enum virtio_gpu_base_conf_flags { VIRTIO_GPU_FLAG_DMABUF_ENABLED, VIRTIO_GPU_FLAG_BLOB_ENABLED, VIRTIO_GPU_FLAG_CONTEXT_INIT_ENABLED, + VIRTIO_GPU_FLAG_RUTABAGA_ENABLED, }; #define virtio_gpu_virgl_enabled(_cfg) \ @@ -108,6 +112,8 @@ enum virtio_gpu_base_conf_flags { (_cfg.flags & (1 << VIRTIO_GPU_FLAG_BLOB_ENABLED)) #define virtio_gpu_context_init_enabled(_cfg) \ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_CONTEXT_INIT_ENABLED)) +#define virtio_gpu_rutabaga_enabled(_cfg) \ + (_cfg.flags & (1 << VIRTIO_GPU_FLAG_RUTABAGA_ENABLED)) #define virtio_gpu_hostmem_enabled(_cfg) \ (_cfg.hostmem > 0) @@ -232,6 +238,28 @@ struct VhostUserGPU { bool backend_blocked; }; +#define MAX_SLOTS 4096 + +struct MemoryRegionInfo { + int used; + MemoryRegion mr; + uint32_t resource_id; +}; + +struct rutabaga; + +struct VirtIOGPURutabaga { + struct VirtIOGPU parent_obj; + + struct MemoryRegionInfo memory_regions[MAX_SLOTS]; + char *capset_names; + char *wayland_socket_path; + char *wsi; + bool headless; + uint32_t num_capsets; + struct rutabaga *rutabaga; +}; + #define VIRTIO_GPU_FILL_CMD(out) do { \ size_t s; \ s = iov_to_buf(cmd->elem.out_sg, cmd->elem.out_num, 0, \