| Message ID | 20230823085429.20519-15-mads@ynddal.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | simpletrace: refactor and general improvements | expand |
On 23/8/23 10:54, Mads Ynddal wrote: > From: Mads Ynddal <m.ynddal@samsung.com> > > Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This > means the script curerntly doesn't work on Python 3. "currently" Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > Signed-off-by: Mads Ynddal <m.ynddal@samsung.com> > --- > scripts/analyse-locks-simpletrace.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, Aug 23, 2023 at 10:54:29AM +0200, Mads Ynddal wrote: > From: Mads Ynddal <m.ynddal@samsung.com> > > Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This > means the script curerntly doesn't work on Python 3. > > Signed-off-by: Mads Ynddal <m.ynddal@samsung.com> > --- > scripts/analyse-locks-simpletrace.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/scripts/analyse-locks-simpletrace.py b/scripts/analyse-locks-simpletrace.py index 63c11f4fce..d650dd7140 100755 --- a/scripts/analyse-locks-simpletrace.py +++ b/scripts/analyse-locks-simpletrace.py @@ -75,7 +75,7 @@ def get_args(): (analyser.locks, analyser.locked, analyser.unlocks)) # Now dump the individual lock stats - for key, val in sorted(analyser.mutex_records.iteritems(), + for key, val in sorted(analyser.mutex_records.items(), key=lambda k_v: k_v[1]["locks"]): print ("Lock: %#x locks: %d, locked: %d, unlocked: %d" % (key, val["locks"], val["locked"], val["unlocked"]))