| Message ID | 20230907034228.4054839-1-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I guess the last time I sent IDE patches was for 6.2 and that tag got stuck in my git-publish invocation, oops. I am not suggesting we break the laws of causality to merge these patches. On Wed, Sep 6, 2023 at 11:42 PM John Snow <jsnow@redhat.com> wrote: > > The following changes since commit c152379422a204109f34ca2b43ecc538c7d738ae: > > Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-09-06 11:16:01 -0400) > > are available in the Git repository at: > > https://gitlab.com/jsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 9f89423537653de07ca40c18b5ff5b70b104cc93: > > hw/ide/ahci: fix broken SError handling (2023-09-06 22:48:04 -0400) > > ---------------------------------------------------------------- > IDE Pull request > > ---------------------------------------------------------------- > > Niklas Cassel (7): > hw/ide/core: set ERR_STAT in unsupported command completion > hw/ide/ahci: write D2H FIS when processing NCQ command > hw/ide/ahci: simplify and document PxCI handling > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set > hw/ide/ahci: fix ahci_write_fis_sdb() > hw/ide/ahci: fix broken SError handling > > tests/qtest/libqos/ahci.h | 8 ++- > hw/ide/ahci.c | 110 +++++++++++++++++++++++++++----------- > hw/ide/core.c | 2 +- > tests/qtest/libqos/ahci.c | 106 +++++++++++++++++++++++++++--------- > 4 files changed, 163 insertions(+), 63 deletions(-) > > -- > 2.41.0 > >
On 7/9/23 05:43, John Snow wrote: > I guess the last time I sent IDE patches was for 6.2 and that tag got > stuck in my git-publish invocation, oops. I am not suggesting we break > the laws of causality to merge these patches. lol > On Wed, Sep 6, 2023 at 11:42 PM John Snow <jsnow@redhat.com> wrote: >> >> The following changes since commit c152379422a204109f34ca2b43ecc538c7d738ae: >> >> Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-09-06 11:16:01 -0400) >> >> are available in the Git repository at: >> >> https://gitlab.com/jsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to 9f89423537653de07ca40c18b5ff5b70b104cc93: >> >> hw/ide/ahci: fix broken SError handling (2023-09-06 22:48:04 -0400) >> >> ---------------------------------------------------------------- >> IDE Pull request \o/ >> ---------------------------------------------------------------- >> >> Niklas Cassel (7): >> hw/ide/core: set ERR_STAT in unsupported command completion >> hw/ide/ahci: write D2H FIS when processing NCQ command >> hw/ide/ahci: simplify and document PxCI handling >> hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared >> hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set >> hw/ide/ahci: fix ahci_write_fis_sdb() >> hw/ide/ahci: fix broken SError handling
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes.
07.09.2023 06:42, John Snow wrote: > ---------------------------------------------------------------- > IDE Pull request > > ---------------------------------------------------------------- > > Niklas Cassel (7): > hw/ide/core: set ERR_STAT in unsupported command completion > hw/ide/ahci: write D2H FIS when processing NCQ command > hw/ide/ahci: simplify and document PxCI handling > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set > hw/ide/ahci: fix ahci_write_fis_sdb() > hw/ide/ahci: fix broken SError handling Is anything here stable-worthy? /mjt
On Thu, Sep 7, 2023, 12:49 PM Michael Tokarev <mjt@tls.msk.ru> wrote: > 07.09.2023 06:42, John Snow wrote: > > > ---------------------------------------------------------------- > > IDE Pull request > > > > ---------------------------------------------------------------- > > > > Niklas Cassel (7): > > hw/ide/core: set ERR_STAT in unsupported command completion > > hw/ide/ahci: write D2H FIS when processing NCQ command > > hw/ide/ahci: simplify and document PxCI handling > > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared > > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set > > hw/ide/ahci: fix ahci_write_fis_sdb() > > hw/ide/ahci: fix broken SError handling > > Is anything here stable-worthy? > > /mjt > Yes, assuming it doesn't break anything. I can't give IDE the testing it deserves anymore, but I trust Niklas. I don't have good test suites for *inside* linux/windows guests so I am admittedly relying on qtests and for people to bark if something regressed. I'd say to tentatively add them to your list and if we find regressions during this window, we can exclude them from a stable release. >
07.09.2023 19:54, John Snow wrote: .. > > ---------------------------------------------------------------- > > > > Niklas Cassel (7): > > hw/ide/core: set ERR_STAT in unsupported command completion > > hw/ide/ahci: write D2H FIS when processing NCQ command > > hw/ide/ahci: simplify and document PxCI handling > > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared > > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set > > hw/ide/ahci: fix ahci_write_fis_sdb() > > hw/ide/ahci: fix broken SError handling > > Is anything here stable-worthy? > > Yes, assuming it doesn't break anything. Hmm. I was thinking maybe one or two of the above. Are you suggesting the *whole* lot? > I can't give IDE the testing it deserves anymore, but I trust Niklas. I don't have good test suites for *inside* linux/windows guests so I am > admittedly relying on qtests and for people to bark if something regressed. > > I'd say to tentatively add them to your list and if we find regressions during this window, we can exclude them from a stable release. Yeah, sure, that's okay. Thank you! /mjt
On 7/9/23 20:16, Michael Tokarev wrote: > 07.09.2023 19:54, John Snow wrote: > .. >> > ---------------------------------------------------------------- >> > >> > Niklas Cassel (7): >> > hw/ide/core: set ERR_STAT in unsupported command completion >> > hw/ide/ahci: write D2H FIS when processing NCQ command >> > hw/ide/ahci: simplify and document PxCI handling >> > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is >> cleared >> > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set >> > hw/ide/ahci: fix ahci_write_fis_sdb() >> > hw/ide/ahci: fix broken SError handling >> >> Is anything here stable-worthy? >> >> Yes, assuming it doesn't break anything. > > Hmm. I was thinking maybe one or two of the above. > Are you suggesting the *whole* lot? Yes :/
08.09.2023 10:53, Philippe Mathieu-Daudé wrote: > On 7/9/23 20:16, Michael Tokarev wrote: >> 07.09.2023 19:54, John Snow wrote: >> .. >>> > ---------------------------------------------------------------- >>> > >>> > Niklas Cassel (7): >>> > hw/ide/core: set ERR_STAT in unsupported command completion >>> > hw/ide/ahci: write D2H FIS when processing NCQ command >>> > hw/ide/ahci: simplify and document PxCI handling >>> > hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared >>> > hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set >>> > hw/ide/ahci: fix ahci_write_fis_sdb() >>> > hw/ide/ahci: fix broken SError handling >>> >>> Is anything here stable-worthy? >>> >>> Yes, assuming it doesn't break anything. >> >> Hmm. I was thinking maybe one or two of the above. >> Are you suggesting the *whole* lot? > > Yes :/ This smells a bit extreme, esp. for the "simplify and document PxCI handling" part which is one of the largest patches in whole -stable history. But it applies cleanly to 8.1, 8.0 and 7.2 (with minor obvious context tweak needed for <=8.0), and seems to work too - I pushed it for testing yesterday to make sure. Picked whole thing up for -stable. Thank you all! /mjt
08.09.2023 11:06, Michael Tokarev wrote: .. > This smells a bit extreme, esp. for the "simplify and document PxCI handling" > part which is one of the largest patches in whole -stable history. or maybe it's just the excellent commit comment ;) /mjt