[v2,1/3] i386/a-b-bootblock: factor test memory addresses out into constants

Commit Message

Daniil Tatianin Sept. 19, 2023, 10:23 a.m. UTC

So that we have less magic numbers to deal with. This also allows us to
reuse these in the following commits.

Signed-off-by: Daniil Tatianin <[e-mail]>
Reviewed-by: Peter Xu <[e-mail]>
---
 tests/migration/i386/a-b-bootblock.S | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Vladimir Sementsov-Ogievskiy Sept. 26, 2023, 9:22 p.m. UTC | #1

On 19.09.23 13:23, Daniil Tatianin wrote:
> So that we have less magic numbers to deal with. This also allows us to
> reuse these in the following commits.
> 
> Signed-off-by: Daniil Tatianin<[e-mail]>
> Reviewed-by: Peter Xu<[e-mail]>


Reviewed-by: Vladimir Sementsov-Ogievskiy <[e-mail]>

Juan Quintela Oct. 4, 2023, 8:50 a.m. UTC | #2

Daniil Tatianin <[e-mail]> wrote:
> So that we have less magic numbers to deal with. This also allows us to
> reuse these in the following commits.
>
> Signed-off-by: Daniil Tatianin <[e-mail]>
> Reviewed-by: Peter Xu <[e-mail]>

Reviewed-by: Juan Quintela <[e-mail]>

queued.

Patch

diff --git a/tests/migration/i386/a-b-bootblock.S b/tests/migration/i386/a-b-bootblock.S
index 3d464c7568..036216e4a7 100644
--- a/tests/migration/i386/a-b-bootblock.S
+++ b/tests/migration/i386/a-b-bootblock.S
@@ -34,6 +34,10 @@  start:             # at 0x7c00 ?
         mov $16,%eax
         mov %eax,%ds
 
+# Start from 1MB
+.set TEST_MEM_START, (1024*1024)
+.set TEST_MEM_END, (100*1024*1024)
+
         mov $65,%ax
         mov $0x3f8,%dx
         outb %al,%dx
@@ -41,12 +45,11 @@  start:             # at 0x7c00 ?
         # bl keeps a counter so we limit the output speed
         mov $0, %bl
 mainloop:
-        # Start from 1MB
-        mov $(1024*1024),%eax
+        mov $TEST_MEM_START,%eax
 innerloop:
         incb (%eax)
         add $4096,%eax
-        cmp $(100*1024*1024),%eax
+        cmp $TEST_MEM_END,%eax
         jl innerloop
 
         inc %bl