| Message ID | 20231116131454.541434-4-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Limit type names to alphanumerical and some few special characters | expand |
On 16.11.23 14:14, Thomas Huth wrote: > Type names should not contain special characters like ":". Let's > remove the whole prefix here since it does not really seem to be > helpful to have such a prefix here. The type name is only used > internally for an interface, so the renaming should not affect > the user interface or migration. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > include/exec/memory.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 831f7c996d..f172e82ac9 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -43,7 +43,7 @@ typedef struct IOMMUMemoryRegionClass IOMMUMemoryRegionClass; > DECLARE_OBJ_CHECKERS(IOMMUMemoryRegion, IOMMUMemoryRegionClass, > IOMMU_MEMORY_REGION, TYPE_IOMMU_MEMORY_REGION) > > -#define TYPE_RAM_DISCARD_MANAGER "qemu:ram-discard-manager" > +#define TYPE_RAM_DISCARD_MANAGER "ram-discard-manager" > typedef struct RamDiscardManagerClass RamDiscardManagerClass; > typedef struct RamDiscardManager RamDiscardManager; > DECLARE_OBJ_CHECKERS(RamDiscardManager, RamDiscardManagerClass, Reviewed-by: David Hildenbrand <david@redhat.com>
On 16/11/23 14:14, Thomas Huth wrote: > Type names should not contain special characters like ":". Let's > remove the whole prefix here since it does not really seem to be > helpful to have such a prefix here. The type name is only used > internally for an interface, so the renaming should not affect > the user interface or migration. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > include/exec/memory.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/include/exec/memory.h b/include/exec/memory.h index 831f7c996d..f172e82ac9 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -43,7 +43,7 @@ typedef struct IOMMUMemoryRegionClass IOMMUMemoryRegionClass; DECLARE_OBJ_CHECKERS(IOMMUMemoryRegion, IOMMUMemoryRegionClass, IOMMU_MEMORY_REGION, TYPE_IOMMU_MEMORY_REGION) -#define TYPE_RAM_DISCARD_MANAGER "qemu:ram-discard-manager" +#define TYPE_RAM_DISCARD_MANAGER "ram-discard-manager" typedef struct RamDiscardManagerClass RamDiscardManagerClass; typedef struct RamDiscardManager RamDiscardManager; DECLARE_OBJ_CHECKERS(RamDiscardManager, RamDiscardManagerClass,
Type names should not contain special characters like ":". Let's remove the whole prefix here since it does not really seem to be helpful to have such a prefix here. The type name is only used internally for an interface, so the renaming should not affect the user interface or migration. Signed-off-by: Thomas Huth <thuth@redhat.com> --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)