| Message ID | 20231116131454.541434-5-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Limit type names to alphanumerical and some few special characters | expand |
On Thu, Nov 16, 2023 at 02:14:53PM +0100, Thomas Huth wrote: > Type names should not contain special characters like ":" (so that > they are easier to use with QAPI and other parts). We are going to > forbid such names in an upcoming patch. Thus let's replace the ":" > here with a "-". > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/unit/test-io-task.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On 16/11/23 14:14, Thomas Huth wrote: > Type names should not contain special characters like ":" (so that > they are easier to use with QAPI and other parts). We are going to > forbid such names in an upcoming patch. Thus let's replace the ":" > here with a "-". > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/unit/test-io-task.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/tests/unit/test-io-task.c b/tests/unit/test-io-task.c index 953a50ae66..115dba8970 100644 --- a/tests/unit/test-io-task.c +++ b/tests/unit/test-io-task.c @@ -25,7 +25,7 @@ #include "qapi/error.h" #include "qemu/module.h" -#define TYPE_DUMMY "qemu:dummy" +#define TYPE_DUMMY "qemu-dummy" typedef struct DummyObject DummyObject; typedef struct DummyObjectClass DummyObjectClass;
Type names should not contain special characters like ":" (so that they are easier to use with QAPI and other parts). We are going to forbid such names in an upcoming patch. Thus let's replace the ":" here with a "-". Signed-off-by: Thomas Huth <thuth@redhat.com> --- tests/unit/test-io-task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)