From patchwork Sat Nov 18 02:24:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dehan Meng X-Patchwork-Id: 13459818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 345C7C197A0 for ; Sat, 18 Nov 2023 02:26:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4B27-0006i9-9J; Fri, 17 Nov 2023 21:26:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4B25-0006hj-F3 for qemu-devel@nongnu.org; Fri, 17 Nov 2023 21:26:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4B21-0000gs-PK for qemu-devel@nongnu.org; Fri, 17 Nov 2023 21:26:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700274361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=keZnHuG7P8xBB9h7Yrga9Zc6p1ydIWQxCuNT1SYHShk=; b=OOqeFHazW3WCJ0EQzRfiblgBOIPJK8Rb9G+FZqYeV4wVHY7wK9nv6kovWHfXshdDBDyFzD 7nm1OggGFJAYVxRP64GsgcMo7SRZsHTXoMinT4RwHNt8K8K+tVD3qAc1MQBWF7jFx91f0V Q72fNByvyrIUzamx9/n8cVlq148ZFV8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-jGZWedWRNMywk1aHm32JFA-1; Fri, 17 Nov 2023 21:24:35 -0500 X-MC-Unique: jGZWedWRNMywk1aHm32JFA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDD363C01C29; Sat, 18 Nov 2023 02:24:34 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADF415028; Sat, 18 Nov 2023 02:24:32 +0000 (UTC) From: Dehan Meng To: qemu-devel@nongnu.org Cc: demeng@redhat.com, kkostiuk@redhat.com, michael.roth@amd.com Subject: [PATCH] qga/linux: Add new api 'guest-network-get-route' Date: Sat, 18 Nov 2023 10:24:28 +0800 Message-Id: <20231118022428.118778-1-demeng@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=demeng@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng --- qga/commands-posix.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ qga/commands-win32.c | 6 ++++ qga/qapi-schema.json | 80 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 168 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 6169bbf7a0..83a3c46b3c 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2747,6 +2747,82 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp) return head; } +char *hexToIPAddress(unsigned int hexValue, char ipAddress[16]); + +char *hexToIPAddress(unsigned int hexValue, char ipAddress[16]) +{ + unsigned int byte1 = (hexValue >> 24) & 0xFF; + unsigned int byte2 = (hexValue >> 16) & 0xFF; + unsigned int byte3 = (hexValue >> 8) & 0xFF; + unsigned int byte4 = hexValue & 0xFF; + + snprintf(ipAddress, 16, "%u.%u.%u.%u", byte4, byte3, byte2, byte1); + + return ipAddress; +} + +GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) +{ + GuestNetworkRouteList *head = NULL, **tail = &head; + const char *routeFile = "/proc/net/route"; + FILE *fp; + size_t n; + char *line = NULL; + + fp = fopen(routeFile, "r"); + if (fp == NULL) { + error_setg_errno(errp, errno, "open(\"%s\")", routeFile); + return NULL; + } + + while (getline(&line, &n, fp) != -1) { + GuestNetworkRoute *route = NULL; + GuestNetworkRouteStat *networkroute; + int i; + char Iface[16]; + unsigned int Destination, Gateway, Mask, Flags; + int RefCnt, Use, Metric, MTU, Window, IRTT; + + /* Parse the line and extract the values */ + i = (sscanf(line, "%s %X %X %x %d %d %d %X %d %d %d", + Iface, &Destination, &Gateway, &Flags, &RefCnt, + &Use, &Metric, &Mask, &MTU, &Window, &IRTT) == 11); + if (i == EOF) { + continue; + } + + route = g_new0(GuestNetworkRoute, 1); + route->type = GUEST_NETWORK_ROUTE_TYPE_LINUX; + + /* + *Additional logic to convert hex values to + *decimal and IP address format + */ + char DestAddress[16]; + char GateAddress[16]; + char MaskAddress[16]; + + networkroute = &route->u.q_linux; + networkroute->iface = g_strdup(Iface); + networkroute->destination = hexToIPAddress(Destination, DestAddress); + networkroute->gateway = hexToIPAddress(Gateway, GateAddress); + networkroute->mask = hexToIPAddress(Mask, MaskAddress); + networkroute->metric = Metric; + networkroute->flags = Flags; + networkroute->refcnt = RefCnt; + networkroute->use = Use; + networkroute->mtu = MTU; + networkroute->window = Window; + networkroute->irtt = IRTT; + + QAPI_LIST_APPEND(tail, route); + } + + free(line); + fclose(fp); + return head; +} + #else /* defined(__linux__) */ void qmp_guest_suspend_disk(Error **errp) @@ -3118,6 +3194,12 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp) return NULL; } +GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) +{ + error_setg(errp, QERR_UNSUPPORTED); + return NULL; +} + #endif /* CONFIG_FSFREEZE */ #if !defined(CONFIG_FSTRIM) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 697c65507c..e62c04800a 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -2522,3 +2522,9 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp) error_setg(errp, QERR_UNSUPPORTED); return NULL; } + +GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) +{ + error_setg(errp, QERR_UNSUPPORTED); + return NULL; +} diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 876e2a8ea8..eed9539bb7 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1789,3 +1789,83 @@ { 'command': 'guest-get-cpustats', 'returns': ['GuestCpuStats'] } + +## +# @GuestNetworkRouteType: +# +# An enumeration of OS type +# +# Since: 8.2 +## +{ 'enum': 'GuestNetworkRouteType', + 'data': [ 'linux' ] } + +## +# @GuestNetworkRouteStat: +# +# Route information, currently, only linux supported. +# +# @iface: The destination network or host's egress network interface in the routing table +# +# @destination: The IP address of the target network or host, The final destination of the packet +# +# @gateway: The IP address of the next hop router +# +# @mask: Subnet Mask +# +# @metric: Route metric +# +# @flags: Route flags (not for windows) +# +# @irtt: Initial round-trip delay (not for windows) +# +# @refcnt: The route's reference count (not for windows) +# +# @use: Route usage count (not for windows) +# +# @window: TCP window size, used for flow control (not for windows) +# +# @mtu: Data link layer maximum packet size (not for windows) +# +# Since: 8.2 + +## +{ 'struct': 'GuestNetworkRouteStat', + 'data': {'iface': 'str', + 'destination': 'str', + 'gateway': 'str', + 'metric': 'int', + 'mask': 'str', + '*irtt': 'int', + '*flags': 'uint64', + '*refcnt': 'int', + '*use': 'int', + '*window': 'int', + '*mtu': 'int' + }} + +## +# @GuestNetworkRoute: +# +# Get route information of system. +# +# - @linux: Linux style network route +# +# Since: 8.2 +## +{ 'union': 'GuestNetworkRoute', + 'base': { 'type': 'GuestNetworkRouteType' }, + 'discriminator': 'type', + 'data': { 'linux': 'GuestNetworkRouteStat' } } + +## +# @guest-network-get-route: +# +# Retrieve information about route of network. +# Returns: List of route info of guest. +# +# Since: 8.2 +## +{ 'command': 'guest-network-get-route', + 'returns': ['GuestNetworkRoute'] +}