| Message ID | 20231127145611.925817-3-zhao1.liu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Cleanup unused included header in core.c & cluster.c | expand |
On 27/11/23 15:56, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > > Remove unused header (qemu/module.h and qemu/cutils.h) in cluster.c, > and reorder the remaining header files (except qemu/osdep.h) in > alphabetical order. > > Tested by "./configure" and then "make". > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > --- > hw/cpu/cluster.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Tue, Nov 28, 2023 at 11:02:00AM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 28 Nov 2023 11:02:00 +0100 > From: Philippe Mathieu-Daudé <philmd@linaro.org> > Subject: Re: [PATCH 2/2] hw/cpu/cluster: Cleanup unused included header in > cluster.c > > On 27/11/23 15:56, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > Remove unused header (qemu/module.h and qemu/cutils.h) in cluster.c, > > and reorder the remaining header files (except qemu/osdep.h) in > > alphabetical order. > > > > Tested by "./configure" and then "make". > > > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > > --- > > hw/cpu/cluster.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Thanks Philippe! BTW, could these two patches be merged into your next tree? I also find these 2 headers are included in many cases, maybe I can go further and do a more thorough cleaning. Regards, Zhao
diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c index e444b7c29d1b..61289a840d46 100644 --- a/hw/cpu/cluster.c +++ b/hw/cpu/cluster.c @@ -19,12 +19,11 @@ */ #include "qemu/osdep.h" + +#include "hw/core/cpu.h" #include "hw/cpu/cluster.h" #include "hw/qdev-properties.h" -#include "hw/core/cpu.h" #include "qapi/error.h" -#include "qemu/module.h" -#include "qemu/cutils.h" static Property cpu_cluster_properties[] = { DEFINE_PROP_UINT32("cluster-id", CPUClusterState, cluster_id, 0),