| Message ID | 20231213105026.1944656-7-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PULL,1/6] tests/acpi: allow tests/data/acpi/virt/SSDT.memhp changes | expand |
> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann <kraxel@redhat.com> wrote: > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Please combine this patch with patch 5. No need to do this separately. > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index e569098abddc..dfb8523c8bf4 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,2 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/virt/SSDT.memhp", > -- > 2.43.0 >
On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote: > > > > On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann <kraxel@redhat.com> wrote: > > > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > Please combine this patch with patch 5. No need to do this separately. Yes but since it's done - it's fine either way I think. No? > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > > index e569098abddc..dfb8523c8bf4 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1,2 +1 @@ > > /* List of comma-separated changed AML files to ignore */ > > -"tests/data/acpi/virt/SSDT.memhp", > > -- > > 2.43.0 > >
> On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote: >> >> >>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann <kraxel@redhat.com> wrote: >>> >>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> >> >> Please combine this patch with patch 5. No need to do this separately. > > > Yes but since it's done - it's fine either way I think. No? Yes I did not realise it was a PR and not a review. I thought it was sent for review. If it’s done it’s ok. That being said, I would have preferred that the commit had a description and not completely empty. > >>> --- >>> tests/qtest/bios-tables-test-allowed-diff.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h >>> index e569098abddc..dfb8523c8bf4 100644 >>> --- a/tests/qtest/bios-tables-test-allowed-diff.h >>> +++ b/tests/qtest/bios-tables-test-allowed-diff.h >>> @@ -1,2 +1 @@ >>> /* List of comma-separated changed AML files to ignore */ >>> -"tests/data/acpi/virt/SSDT.memhp", >>> -- >>> 2.43.0 >>> >
On Wed, Dec 13, 2023 at 08:09:29PM +0530, Ani Sinha wrote: > > > > On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote: > >> > >> > >>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann <kraxel@redhat.com> wrote: > >>> > >>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > >> > >> Please combine this patch with patch 5. No need to do this separately. > > > > > > Yes but since it's done - it's fine either way I think. No? > > Yes I did not realise it was a PR and not a review. I thought it was sent for review. If it’s done it’s ok. > That being said, I would have preferred that the commit had a description and not completely empty. I agree, Gerd, going forward please include the diff of the disassemled AML. > > > >>> --- > >>> tests/qtest/bios-tables-test-allowed-diff.h | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > >>> index e569098abddc..dfb8523c8bf4 100644 > >>> --- a/tests/qtest/bios-tables-test-allowed-diff.h > >>> +++ b/tests/qtest/bios-tables-test-allowed-diff.h > >>> @@ -1,2 +1 @@ > >>> /* List of comma-separated changed AML files to ignore */ > >>> -"tests/data/acpi/virt/SSDT.memhp", > >>> -- > >>> 2.43.0 > >>> > >
Hi, > I agree, Gerd, going forward please include the diff of the > disassemled AML. That is in patch 5/6 which updates the test data. take care, Gerd
On Wed, Dec 13, 2023 at 04:14:00PM +0100, Gerd Hoffmann wrote: > Hi, > > > I agree, Gerd, going forward please include the diff of the > > disassemled AML. > > That is in patch 5/6 which updates the test data. > > take care, > Gerd Oh I double checked and you are right, I'm not sure where did I look that I missed it. Pls ignore.
> On 13-Dec-2023, at 8:47 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Dec 13, 2023 at 04:14:00PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> I agree, Gerd, going forward please include the diff of the >>> disassemled AML. >> >> That is in patch 5/6 which updates the test data. >> >> take care, >> Gerd > > Oh I double checked and you are right, I'm not sure where did I look that I missed it. Yes I was talking about patch 6 having an empty description.
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index e569098abddc..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/virt/SSDT.memhp",
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-)