diff mbox series

[01/12] next-cube.c: add dummy Ethernet register to allow diagnostic to timeout

Message ID 20231215200009.346212-2-mark.cave-ayland@ilande.co.uk (mailing list archive)
State New, archived
Headers show
Series next-cube: various tidy-ups and improvements | expand

Commit Message

Mark Cave-Ayland Dec. 15, 2023, 7:59 p.m. UTC
Add a dummy register at address 0x6000 in the MMIO memory region to allow the
initial diagnostic test to timeout rather than getting stuck in a loop
continuously writing "en_write: tx not ready" to the console.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/m68k/next-cube.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Huth Dec. 16, 2023, 9 a.m. UTC | #1
Am Fri, 15 Dec 2023 19:59:58 +0000
schrieb Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>:

> Add a dummy register at address 0x6000 in the MMIO memory region to allow the
> initial diagnostic test to timeout rather than getting stuck in a loop
> continuously writing "en_write: tx not ready" to the console.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/m68k/next-cube.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
> index fabd861941..feeda23475 100644
> --- a/hw/m68k/next-cube.c
> +++ b/hw/m68k/next-cube.c
> @@ -429,6 +429,10 @@ static uint32_t scr_readb(NeXTPC *s, hwaddr addr)
>          /* Hack: We need to have this change consistently to make it work */
>          return 0xFF & clock();
>  
> +    /* For now return dummy byte to allow the Ethernet test to timeout */
> +    case 0x6000:
> +        return 0xff;
> +

Good idea!

Tested-by: Thomas Huth <huth@tuxfamily.org>
diff mbox series

Patch

diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index fabd861941..feeda23475 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -429,6 +429,10 @@  static uint32_t scr_readb(NeXTPC *s, hwaddr addr)
         /* Hack: We need to have this change consistently to make it work */
         return 0xFF & clock();
 
+    /* For now return dummy byte to allow the Ethernet test to timeout */
+    case 0x6000:
+        return 0xff;
+
     default:
         DPRINTF("BMAP Read B @ %x\n", (unsigned int)addr);
         return 0;