From patchwork Thu Dec 21 19:24:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 13502593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7C15C46CD8 for ; Thu, 21 Dec 2023 19:25:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGOfU-0001QI-6v; Thu, 21 Dec 2023 14:25:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGOfS-0001PP-KR for qemu-devel@nongnu.org; Thu, 21 Dec 2023 14:25:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGOfI-0001zf-AP for qemu-devel@nongnu.org; Thu, 21 Dec 2023 14:25:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703186703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TWS9d0MNzNV2xV2VNA1Huwo4h7Tta7bQDm7YpCyuZCc=; b=eWYK3+6aHYzn+6lhmjvrGOUZ3GPewINZKK1smmxYp5I4fOg69EFzwZznKR7WDozXJ7wWxd 3Um4BO8Zragyf8F7qbEKjaqgMnPPszApFcBXIWkJ4QG+FvMoIbF342w3e+FbjAhTqN2JdU mWqqL8MbsF51P2FMen55QRopR8rFrGM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398--VRlkOD2PWCUXrmmi7uuiQ-1; Thu, 21 Dec 2023 14:25:01 -0500 X-MC-Unique: -VRlkOD2PWCUXrmmi7uuiQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C519F85A58B; Thu, 21 Dec 2023 19:25:00 +0000 (UTC) Received: from localhost (unknown [10.39.194.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4AE8E492BE6; Thu, 21 Dec 2023 19:25:00 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org, Kevin Wolf Cc: Juan Quintela , Vladimir Sementsov-Ogievskiy , pbonzini@redhat.com, Peter Xu , qemu-block@nongnu.org, Hanna Reitz , Fabiano Rosas , Leonardo Bras , Eric Blake , Stefan Hajnoczi , Fam Zheng Subject: [PATCH v3 3/6] fixup scsi: only access SCSIDevice->requests from one thread Date: Thu, 21 Dec 2023 14:24:49 -0500 Message-ID: <20231221192452.1785567-4-stefanha@redhat.com> In-Reply-To: <20231221192452.1785567-1-stefanha@redhat.com> References: <20231221192452.1785567-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index df68a44b6a..5b08cbf60a 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -127,7 +127,8 @@ static void scsi_device_for_each_req_async_bh(void *opaque) */ ctx = blk_get_aio_context(s->conf.blk); if (ctx != qemu_get_current_aio_context()) { - aio_bh_schedule_oneshot(ctx, scsi_device_for_each_req_async_bh, data); + aio_bh_schedule_oneshot(ctx, scsi_device_for_each_req_async_bh, + g_steal_pointer(&data)); return; }