diff mbox series

[v2,1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss

Message ID 20240102020200.3462097-1-gaosong@loongson.cn (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss | expand

Commit Message

Song Gao Jan. 2, 2024, 2:01 a.m. UTC
gdbstub.c is not specific to TCG and can be used by
other accelerators, such as KVM accelerator

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 target/loongarch/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Jan. 2, 2024, 9:46 a.m. UTC | #1
On 2/1/24 03:01, Song Gao wrote:
> gdbstub.c is not specific to TCG and can be used by
> other accelerators, such as KVM accelerator
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

I didn't really suggested the change but the split ;)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
Song Gao Jan. 2, 2024, 12:05 p.m. UTC | #2
在 2024/1/2 下午5:46, Philippe Mathieu-Daudé 写道:
> On 2/1/24 03:01, Song Gao wrote:
>> gdbstub.c is not specific to TCG and can be used by
>> other accelerators, such as KVM accelerator
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> I didn't really suggested the change but the split ;)
>
Ah,  I can drop it for pull request.

Thanks.
Song Gao.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>> ---
>>   target/loongarch/meson.build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
diff mbox series

Patch

diff --git a/target/loongarch/meson.build b/target/loongarch/meson.build
index 18e8191e2b..b3a0fb12fb 100644
--- a/target/loongarch/meson.build
+++ b/target/loongarch/meson.build
@@ -3,6 +3,7 @@  gen = decodetree.process('insns.decode')
 loongarch_ss = ss.source_set()
 loongarch_ss.add(files(
   'cpu.c',
+  'gdbstub.c',
 ))
 loongarch_tcg_ss = ss.source_set()
 loongarch_tcg_ss.add(gen)
@@ -10,7 +11,6 @@  loongarch_tcg_ss.add(files(
   'fpu_helper.c',
   'op_helper.c',
   'translate.c',
-  'gdbstub.c',
   'vec_helper.c',
 ))
 loongarch_tcg_ss.add(zlib)