| Message ID | 20240112222945.3033854-12-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qapi: statically type schema.py | expand |
John Snow <jsnow@redhat.com> writes: > Adjust the expression at the callsite to eliminate weak type > introspection that believes this value can resolve to QAPISourceInfo; it > cannot. What do you mean by "weak type introspection"? mypy being underpowered? > Signed-off-by: John Snow <jsnow@redhat.com> > --- > scripts/qapi/schema.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py > index 35638c7708a..43af756ed47 100644 > --- a/scripts/qapi/schema.py > +++ b/scripts/qapi/schema.py > @@ -403,7 +403,7 @@ def check(self, schema): > super().check(schema) > self.element_type = schema.resolve_type( > self._element_type_name, self.info, > - self.info and self.info.defn_meta) > + self.info.defn_meta if self.info else None) > assert not isinstance(self.element_type, QAPISchemaArrayType) > > def set_module(self, schema):
On Tue, Jan 16, 2024 at 7:17 AM Markus Armbruster <armbru@redhat.com> wrote: > > John Snow <jsnow@redhat.com> writes: > > > Adjust the expression at the callsite to eliminate weak type > > introspection that believes this value can resolve to QAPISourceInfo; it > > cannot. > > What do you mean by "weak type introspection"? mypy being underpowered? Yeah, s'what I meant. > > > Signed-off-by: John Snow <jsnow@redhat.com> > > --- > > scripts/qapi/schema.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py > > index 35638c7708a..43af756ed47 100644 > > --- a/scripts/qapi/schema.py > > +++ b/scripts/qapi/schema.py > > @@ -403,7 +403,7 @@ def check(self, schema): > > super().check(schema) > > self.element_type = schema.resolve_type( > > self._element_type_name, self.info, > > - self.info and self.info.defn_meta) > > + self.info.defn_meta if self.info else None) > > assert not isinstance(self.element_type, QAPISchemaArrayType) > > > > def set_module(self, schema): >
John Snow <jsnow@redhat.com> writes: > On Tue, Jan 16, 2024 at 7:17 AM Markus Armbruster <armbru@redhat.com> wrote: >> >> John Snow <jsnow@redhat.com> writes: >> >> > Adjust the expression at the callsite to eliminate weak type >> > introspection that believes this value can resolve to QAPISourceInfo; it >> > cannot. >> >> What do you mean by "weak type introspection"? mypy being underpowered? > > Yeah, s'what I meant. Should be easy to clarify: mention mypy.
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index 35638c7708a..43af756ed47 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -403,7 +403,7 @@ def check(self, schema): super().check(schema) self.element_type = schema.resolve_type( self._element_type_name, self.info, - self.info and self.info.defn_meta) + self.info.defn_meta if self.info else None) assert not isinstance(self.element_type, QAPISchemaArrayType) def set_module(self, schema):
Adjust the expression at the callsite to eliminate weak type introspection that believes this value can resolve to QAPISourceInfo; it cannot. Signed-off-by: John Snow <jsnow@redhat.com> --- scripts/qapi/schema.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)