| Message ID | 20240130155653.142283-2-groug@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi-build: Fix hint messages | expand |
> On 30-Jan-2024, at 21:26, Greg Kurz <groug@kaod.org> wrote: > > error_fprintf() doesn't add newlines. ^^^^^^^^^^^^^^^^^ Should be error_printf(). Ditto for other patches. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index edc979379c03..e990b0ae927f 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) > " migration may not work", > tables_blob->len, legacy_table_size); > error_printf("Try removing CPUs, NUMA nodes, memory slots" > - " or PCI bridges."); > + " or PCI bridges.\n"); > } > g_array_set_size(tables_blob, legacy_table_size); > } else { > @@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) > " migration may not work", > tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2); > error_printf("Try removing CPUs, NUMA nodes, memory slots" > - " or PCI bridges."); > + " or PCI bridges.\n"); > } > acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); > } > -- > 2.43.0 >
On Tue, 30 Jan 2024 21:43:27 +0530 Ani Sinha <anisinha@redhat.com> wrote: > > > > On 30-Jan-2024, at 21:26, Greg Kurz <groug@kaod.org> wrote: > > > > error_fprintf() doesn't add newlines. > > ^^^^^^^^^^^^^^^^^ > > Should be error_printf(). Ditto for other patches. > Thanks. Posted a v2. > > > > Signed-off-by: Greg Kurz <groug@kaod.org> > > --- > > hw/i386/acpi-build.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index edc979379c03..e990b0ae927f 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) > > " migration may not work", > > tables_blob->len, legacy_table_size); > > error_printf("Try removing CPUs, NUMA nodes, memory slots" > > - " or PCI bridges."); > > + " or PCI bridges.\n"); > > } > > g_array_set_size(tables_blob, legacy_table_size); > > } else { > > @@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) > > " migration may not work", > > tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2); > > error_printf("Try removing CPUs, NUMA nodes, memory slots" > > - " or PCI bridges."); > > + " or PCI bridges.\n"); > > } > > acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); > > } > > -- > > 2.43.0 > > >
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index edc979379c03..e990b0ae927f 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) " migration may not work", tables_blob->len, legacy_table_size); error_printf("Try removing CPUs, NUMA nodes, memory slots" - " or PCI bridges."); + " or PCI bridges.\n"); } g_array_set_size(tables_blob, legacy_table_size); } else { @@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) " migration may not work", tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2); error_printf("Try removing CPUs, NUMA nodes, memory slots" - " or PCI bridges."); + " or PCI bridges.\n"); } acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); }
error_fprintf() doesn't add newlines. Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)