From patchwork Tue Feb 13 19:39:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Cave-Ayland X-Patchwork-Id: 13555561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC18CC48260 for ; Tue, 13 Feb 2024 19:42:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZyfz-0005vY-DJ; Tue, 13 Feb 2024 14:42:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZyfv-0005Ws-Ns for qemu-devel@nongnu.org; Tue, 13 Feb 2024 14:42:39 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZyfu-0006OM-9I for qemu-devel@nongnu.org; Tue, 13 Feb 2024 14:42:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7PJF5PajYxkwWq+WBczJf1hF4O+SwUXBWFXRG3xfWu8=; b=PJE/XEiwijUcPB74TVyWd5Dk/j XolD3hOsSf1+Fz2bDkOKMB61+58tl6WKIhVdNAZ6jqczDK0FpCkP7W+Y8jfcunRcY2KAKNQ2X/qqP rjEJ3juSPmVTWR49IxVhSbJnnRJqxYkcw1eVr6cWsfW831tl2rlthzCDj3Lscvqn4/LERQLcvXu03 TptiAQUpTB896xSdiwRFlIlcrjsTZsXW2HI2Sqnv/gy9eakNDsgGZ8Gqn9O7OgVM9+i1AvyOcaWUt nCJ834GoeqiVQqVYo30kJj7b/+4VmXygkrHdb7VTR+FqjjMrJh8533illXUP1GvLOzRvHtwb2ik9e L/iIMvgsTbN1RHA6Ee8ZBmBPlMOepUOb/Jml/bzCeTfTQPfG+3nh4KeF/rGNzbOX4eqMiia+4YM1j ZG1PefilwZ6VQ60jd7i3SS0TONtvdhih/TgEzRWFk+3GJ0gRJW4Lx2OjZ3EHZpUldXp4MBn7BjNDn en6Jwoc04hbnraj6EBnlsMM2wb9DYnOrzpx33QsbGIaC1u3TQHYZSR7EMKTsdEBetyGm2B0gggZOQ fkGxoWdkKNgRusbjF6VZ8bwZY67IG+HdqoifO4dxhZvSDauYhv0vTd77SgVWrt/WQsFbkiNaQIdE7 IOK5FkYGD2t1qHBKH9u8+0hgdw1juBfa9oVHcZuxE=; Received: from [2a00:23c4:8bb2:1300:c500:f104:bc51:e670] (helo=localhost.localdomain) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZyf5-0008m4-5V; Tue, 13 Feb 2024 19:41:47 +0000 From: Mark Cave-Ayland To: peter.maydell@linaro.org, qemu-devel@nongnu.org Date: Tue, 13 Feb 2024 19:39:49 +0000 Message-Id: <20240213194052.1162753-26-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240213194052.1162753-1-mark.cave-ayland@ilande.co.uk> References: <20240213194052.1162753-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a00:23c4:8bb2:1300:c500:f104:bc51:e670 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 25/88] esp.c: remove unaligned adjustment in do_dma_pdma_cb() to device path X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org With the latest changes this condition cannot occur anymore and so the logic can be completely removed. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Tested-by: Thomas Huth Message-Id: <20240112125420.514425-26-mark.cave-ayland@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index ec82097a01..3db90c9ab7 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -604,15 +604,6 @@ static void do_dma_pdma_cb(ESPState *s) s->async_len -= n; s->ti_size += n; - if (n < len) { - /* Unaligned accesses can cause FIFO wraparound */ - len = len - n; - n = esp_fifo_pop_buf(&s->fifo, s->async_buf, len); - s->async_buf += n; - s->async_len -= n; - s->ti_size += n; - } - if (s->async_len == 0) { scsi_req_continue(s->current_req); return;