| Message ID | 20240227223501.28475-8-vikram.garhwal@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Xen: support grant mappings. | expand |
Vikram Garhwal <vikram.garhwal@amd.com> writes: > Enable grant ram mapping support for Xenpvh machine on ARM. > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > hw/arm/xen_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c > index 32776d94df..b5993ef2a6 100644 > --- a/hw/arm/xen_arm.c > +++ b/hw/arm/xen_arm.c > @@ -125,6 +125,9 @@ static void xen_init_ram(MachineState *machine) > GUEST_RAM1_BASE, ram_size[1]); > memory_region_add_subregion(sysmem, GUEST_RAM1_BASE, &ram_hi); > } > + > + DPRINTF("init grant ram mapping for XEN\n"); I don't think we need the DPRINTF here (there others where recently converted to trace-points although I suspect a memory_region tracepoint would be a better place to capture this). > + ram_grants = *xen_init_grant_ram(); > } > > void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
Hi Alex, On Fri, Mar 01, 2024 at 05:10:28PM +0000, Alex Bennée wrote: > Vikram Garhwal <vikram.garhwal@amd.com> writes: > > > Enable grant ram mapping support for Xenpvh machine on ARM. > > > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > --- > > hw/arm/xen_arm.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c > > index 32776d94df..b5993ef2a6 100644 > > --- a/hw/arm/xen_arm.c > > +++ b/hw/arm/xen_arm.c > > @@ -125,6 +125,9 @@ static void xen_init_ram(MachineState *machine) > > GUEST_RAM1_BASE, ram_size[1]); > > memory_region_add_subregion(sysmem, GUEST_RAM1_BASE, &ram_hi); > > } > > + > > + DPRINTF("init grant ram mapping for XEN\n"); > > I don't think we need the DPRINTF here (there others where recently > converted to trace-points although I suspect a memory_region tracepoint > would be a better place to capture this). May be drop the print? As it's not providing much information anyways. > > > + ram_grants = *xen_init_grant_ram(); > > } > > > > void arch_handle_ioreq(XenIOState *state, ioreq_t *req) > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro
On Wed, Mar 6, 2024 at 9:57 PM Vikram Garhwal <vikram.garhwal@amd.com> wrote: > Hi Alex, > On Fri, Mar 01, 2024 at 05:10:28PM +0000, Alex Bennée wrote: > > Vikram Garhwal <vikram.garhwal@amd.com> writes: > > > > > Enable grant ram mapping support for Xenpvh machine on ARM. > > > > > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > --- > > > hw/arm/xen_arm.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c > > > index 32776d94df..b5993ef2a6 100644 > > > --- a/hw/arm/xen_arm.c > > > +++ b/hw/arm/xen_arm.c > > > @@ -125,6 +125,9 @@ static void xen_init_ram(MachineState *machine) > > > GUEST_RAM1_BASE, ram_size[1]); > > > memory_region_add_subregion(sysmem, GUEST_RAM1_BASE, &ram_hi); > > > } > > > + > > > + DPRINTF("init grant ram mapping for XEN\n"); > > > > I don't think we need the DPRINTF here (there others where recently > > converted to trace-points although I suspect a memory_region tracepoint > > would be a better place to capture this). > May be drop the print? As it's not providing much information anyways. > With the DPRINTF dropped: Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c index 32776d94df..b5993ef2a6 100644 --- a/hw/arm/xen_arm.c +++ b/hw/arm/xen_arm.c @@ -125,6 +125,9 @@ static void xen_init_ram(MachineState *machine) GUEST_RAM1_BASE, ram_size[1]); memory_region_add_subregion(sysmem, GUEST_RAM1_BASE, &ram_hi); } + + DPRINTF("init grant ram mapping for XEN\n"); + ram_grants = *xen_init_grant_ram(); } void arch_handle_ioreq(XenIOState *state, ioreq_t *req)