| Message ID | 20240301120641.864047-1-armbru@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | replay: Improve error messages about configuration conflicts | expand |
Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru> On 01.03.2024 15:06, Markus Armbruster wrote: > Improve > > Record/replay feature is not supported for '-rtc base=localtime' > Record/replay feature is not supported for 'smp' > Record/replay feature is not supported for '-snapshot' > > to > > Record/replay is not supported with -rtc base=localtime > Record/replay is not supported with multiple CPUs > Record/replay is not supported with -snapshot > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > replay/replay.c | 2 +- > system/vl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/replay/replay.c b/replay/replay.c > index 3fd241a4fc..a2c576c16e 100644 > --- a/replay/replay.c > +++ b/replay/replay.c > @@ -511,7 +511,7 @@ void replay_add_blocker(const char *feature) > { > Error *reason = NULL; > > - error_setg(&reason, "Record/replay feature is not supported for '%s'", > + error_setg(&reason, "Record/replay is not supported with %s", > feature); > replay_blockers = g_slist_prepend(replay_blockers, reason); > } > diff --git a/system/vl.c b/system/vl.c > index e480afd7a0..cc03a17c09 100644 > --- a/system/vl.c > +++ b/system/vl.c > @@ -1932,7 +1932,7 @@ static void qemu_apply_machine_options(QDict *qdict) > } > > if (current_machine->smp.cpus > 1) { > - replay_add_blocker("smp"); > + replay_add_blocker("multiple CPUs"); > } > } >
On 1/3/24 13:06, Markus Armbruster wrote: > Improve > > Record/replay feature is not supported for '-rtc base=localtime' > Record/replay feature is not supported for 'smp' > Record/replay feature is not supported for '-snapshot' > > to > > Record/replay is not supported with -rtc base=localtime > Record/replay is not supported with multiple CPUs > Record/replay is not supported with -snapshot > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > replay/replay.c | 2 +- > system/vl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/replay/replay.c b/replay/replay.c index 3fd241a4fc..a2c576c16e 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -511,7 +511,7 @@ void replay_add_blocker(const char *feature) { Error *reason = NULL; - error_setg(&reason, "Record/replay feature is not supported for '%s'", + error_setg(&reason, "Record/replay is not supported with %s", feature); replay_blockers = g_slist_prepend(replay_blockers, reason); } diff --git a/system/vl.c b/system/vl.c index e480afd7a0..cc03a17c09 100644 --- a/system/vl.c +++ b/system/vl.c @@ -1932,7 +1932,7 @@ static void qemu_apply_machine_options(QDict *qdict) } if (current_machine->smp.cpus > 1) { - replay_add_blocker("smp"); + replay_add_blocker("multiple CPUs"); } }
Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot' to Record/replay is not supported with -rtc base=localtime Record/replay is not supported with multiple CPUs Record/replay is not supported with -snapshot Signed-off-by: Markus Armbruster <armbru@redhat.com> --- replay/replay.c | 2 +- system/vl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)