| Message ID | 20240308171621.3749894-1-peter.maydell@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/arm: Deprecate various old Arm machine types | expand |
On 3/8/24 07:16, Peter Maydell wrote: > Mark all these machine types as depprecated. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > docs/about/deprecated.rst | 15 +++++++++++++++ > hw/arm/gumstix.c | 2 ++ > hw/arm/mainstone.c | 1 + > hw/arm/nseries.c | 2 ++ > hw/arm/palm.c | 1 + > hw/arm/spitz.c | 1 + > hw/arm/tosa.c | 1 + > hw/arm/z2.c | 1 + > 8 files changed, 24 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 08/03/2024 18.16, Peter Maydell wrote: > QEMU includes some models of old Arm machine types which are > a bit problematic for us because: > * they're written in a very old way that uses numerous APIs that we > would like to get away from (eg they don't use qdev, they use > qemu_system_reset_request(), they use vmstate_register(), etc) > * they've been that way for a decade plus and nobody particularly has > stepped up to try to modernise the code (beyond some occasional > work here and there) > * we often don't have test cases for them, which means that if we > do try to do the necessary refactoring work on them we have no > idea if they even still work at all afterwards > > All these machine types are also of hardware that has largely passed > away into history and where I would not be surprised to find that > e.g. the Linux kernel support was never tested on real hardware > any more. > > After some consultation with the Linux kernel developers, we > are going to deprecate: > > All PXA2xx machines: > > akita Sharp SL-C1000 (Akita) PDA (PXA270) > borzoi Sharp SL-C3100 (Borzoi) PDA (PXA270) > connex Gumstix Connex (PXA255) > mainstone Mainstone II (PXA27x) > spitz Sharp SL-C3000 (Spitz) PDA (PXA270) > terrier Sharp SL-C3200 (Terrier) PDA (PXA270) > tosa Sharp SL-6000 (Tosa) PDA (PXA255) > verdex Gumstix Verdex Pro XL6P COMs (PXA270) > z2 Zipit Z2 (PXA27x) > > All OMAP2 machines: > > n800 Nokia N800 tablet aka. RX-34 (OMAP2420) > n810 Nokia N810 tablet aka. RX-44 (OMAP2420) > > One of the OMAP1 machines: > > cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) > > Rationale: > * for QEMU dropping individual machines is much less beneficial > than if we can drop support for an entire SoC > * the OMAP2 QEMU code in particular is large, old and unmaintained, > and none of the OMAP2 kernel maintainers said they were using > QEMU in any of their testing/development > * although there is a setup that is booting test kernels on some > of the PXA2xx machines, nobody seemed to be using them as part > of their active kernel development and my impression from the > email thread is that PXA is the closest of all these SoC families > to being dropped from the kernel soon > * nobody said they were using cheetah, so it's entirely > untested and quite probably broken > * on the other hand the OMAP1 sx1 model does seem to be being > used as part of kernel development, and there was interest > in keeping collie around > > In particular, the mainstone, tosa and z2 machine types have > already been dropped from Linux. > > Mark all these machine types as depprecated. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > docs/about/deprecated.rst | 15 +++++++++++++++ > hw/arm/gumstix.c | 2 ++ > hw/arm/mainstone.c | 1 + > hw/arm/nseries.c | 2 ++ > hw/arm/palm.c | 1 + > hw/arm/spitz.c | 1 + > hw/arm/tosa.c | 1 + > hw/arm/z2.c | 1 + > 8 files changed, 24 insertions(+) Reviewed-by: Thomas Huth <thuth@redhat.com>
On 8/3/24 18:16, Peter Maydell wrote: > QEMU includes some models of old Arm machine types which are > a bit problematic for us because: > * they're written in a very old way that uses numerous APIs that we > would like to get away from (eg they don't use qdev, they use > qemu_system_reset_request(), they use vmstate_register(), etc) > * they've been that way for a decade plus and nobody particularly has > stepped up to try to modernise the code (beyond some occasional > work here and there) > * we often don't have test cases for them, which means that if we > do try to do the necessary refactoring work on them we have no > idea if they even still work at all afterwards > > All these machine types are also of hardware that has largely passed > away into history and where I would not be surprised to find that > e.g. the Linux kernel support was never tested on real hardware > any more. Thanks for writing that down. > After some consultation with the Linux kernel developers, we > are going to deprecate: > > All PXA2xx machines: > > akita Sharp SL-C1000 (Akita) PDA (PXA270) > borzoi Sharp SL-C3100 (Borzoi) PDA (PXA270) > connex Gumstix Connex (PXA255) > mainstone Mainstone II (PXA27x) > spitz Sharp SL-C3000 (Spitz) PDA (PXA270) > terrier Sharp SL-C3200 (Terrier) PDA (PXA270) > tosa Sharp SL-6000 (Tosa) PDA (PXA255) > verdex Gumstix Verdex Pro XL6P COMs (PXA270) > z2 Zipit Z2 (PXA27x) > > All OMAP2 machines: > > n800 Nokia N800 tablet aka. RX-34 (OMAP2420) > n810 Nokia N810 tablet aka. RX-44 (OMAP2420) > > One of the OMAP1 machines: > > cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) > > Rationale: > * for QEMU dropping individual machines is much less beneficial > than if we can drop support for an entire SoC > * the OMAP2 QEMU code in particular is large, old and unmaintained, > and none of the OMAP2 kernel maintainers said they were using > QEMU in any of their testing/development > * although there is a setup that is booting test kernels on some > of the PXA2xx machines, nobody seemed to be using them as part > of their active kernel development and my impression from the > email thread is that PXA is the closest of all these SoC families > to being dropped from the kernel soon > * nobody said they were using cheetah, so it's entirely > untested and quite probably broken > * on the other hand the OMAP1 sx1 model does seem to be being > used as part of kernel development, and there was interest > in keeping collie around > > In particular, the mainstone, tosa and z2 machine types have > already been dropped from Linux. > > Mark all these machine types as depprecated. Typo "deprecated". > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > docs/about/deprecated.rst | 15 +++++++++++++++ > hw/arm/gumstix.c | 2 ++ > hw/arm/mainstone.c | 1 + > hw/arm/nseries.c | 2 ++ > hw/arm/palm.c | 1 + > hw/arm/spitz.c | 1 + > hw/arm/tosa.c | 1 + > hw/arm/z2.c | 1 + > 8 files changed, 24 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 8565644da6d..7345e9f536a 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -247,6 +247,21 @@ to correct issues, mostly regarding migration compatibility. These are no longer maintained and removing them will make the code easier to read and maintain. Use versions 2.12 and above as a replacement. +Arm machines ``akita``, ``borzoi``, ``cheetah``, ``connex``, ``mainstone``, ``n800``, ``n810``, ``spitz``, ``terrier``, ``tosa``, ``verdex``, ``z2`` (since 9.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +QEMU includes models of some machine types where the QEMU code that +emulates their SoCs is very old and unmaintained. This code is now +blocking our ability to move forward with various changes across +the codebase, and over many years nobody has been interested in +trying to modernise it. We don't expect any of these machines to have +a large number of users, because they're all modelling hardware that +has now passed away into history. We are therefore dropping support +for all machine types using the PXA2xx and OMAP2 SoCs. We are also +dropping the ``cheetah`` OMAP1 board, because we don't have any +test images for it and don't know of anybody who does; the ``sx1`` +and ``sx1-v1`` OMAP1 machines remain supported for now. + Backend options --------------- diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index d5de5409e17..91462691531 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -106,6 +106,7 @@ static void connex_class_init(ObjectClass *oc, void *data) mc->desc = "Gumstix Connex (PXA255)"; mc->init = connex_init; mc->ignore_memory_transaction_failures = true; + mc->deprecation_reason = "machine is old and unmaintained"; } static const TypeInfo connex_type = { @@ -121,6 +122,7 @@ static void verdex_class_init(ObjectClass *oc, void *data) mc->desc = "Gumstix Verdex Pro XL6P COMs (PXA270)"; mc->init = verdex_init; mc->ignore_memory_transaction_failures = true; + mc->deprecation_reason = "machine is old and unmaintained"; mc->default_cpu_type = ARM_CPU_TYPE_NAME("pxa270-c0"); } diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c index d2e2e68aa3f..3a6c22fddbc 100644 --- a/hw/arm/mainstone.c +++ b/hw/arm/mainstone.c @@ -169,6 +169,7 @@ static void mainstone2_machine_init(MachineClass *mc) mc->init = mainstone_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type = ARM_CPU_TYPE_NAME("pxa270-c5"); + mc->deprecation_reason = "machine is old and unmaintained"; } DEFINE_MACHINE("mainstone", mainstone2_machine_init) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 35deb74f655..35364312c73 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -1430,6 +1430,7 @@ static void n800_class_init(ObjectClass *oc, void *data) /* Actually two chips of 0x4000000 bytes each */ mc->default_ram_size = 0x08000000; mc->default_ram_id = "omap2.dram"; + mc->deprecation_reason = "machine is old and unmaintained"; machine_add_audiodev_property(mc); } @@ -1452,6 +1453,7 @@ static void n810_class_init(ObjectClass *oc, void *data) /* Actually two chips of 0x4000000 bytes each */ mc->default_ram_size = 0x08000000; mc->default_ram_id = "omap2.dram"; + mc->deprecation_reason = "machine is old and unmaintained"; machine_add_audiodev_property(mc); } diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 8c4c8316140..e04ac92eb7f 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -309,6 +309,7 @@ static void palmte_machine_init(MachineClass *mc) mc->default_cpu_type = ARM_CPU_TYPE_NAME("ti925t"); mc->default_ram_size = 0x02000000; mc->default_ram_id = "omap1.dram"; + mc->deprecation_reason = "machine is old and unmaintained"; machine_add_audiodev_property(mc); } diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 643a02b1807..62cd55ba914 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -1041,6 +1041,7 @@ static void spitz_common_class_init(ObjectClass *oc, void *data) mc->block_default_type = IF_IDE; mc->ignore_memory_transaction_failures = true; mc->init = spitz_common_init; + mc->deprecation_reason = "machine is old and unmaintained"; machine_add_audiodev_property(mc); } diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c index 3ca2e4459ca..5891f6064f9 100644 --- a/hw/arm/tosa.c +++ b/hw/arm/tosa.c @@ -270,6 +270,7 @@ static void tosapda_machine_init(MachineClass *mc) mc->init = tosa_init; mc->block_default_type = IF_IDE; mc->ignore_memory_transaction_failures = true; + mc->deprecation_reason = "machine is old and unmaintained"; } DEFINE_MACHINE("tosa", tosapda_machine_init) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index eb2ff8dbc84..fc5672e7ab2 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -347,6 +347,7 @@ static void z2_machine_init(MachineClass *mc) mc->init = z2_init; mc->ignore_memory_transaction_failures = true; mc->default_cpu_type = ARM_CPU_TYPE_NAME("pxa270-c5"); + mc->deprecation_reason = "machine is old and unmaintained"; machine_add_audiodev_property(mc); }
QEMU includes some models of old Arm machine types which are a bit problematic for us because: * they're written in a very old way that uses numerous APIs that we would like to get away from (eg they don't use qdev, they use qemu_system_reset_request(), they use vmstate_register(), etc) * they've been that way for a decade plus and nobody particularly has stepped up to try to modernise the code (beyond some occasional work here and there) * we often don't have test cases for them, which means that if we do try to do the necessary refactoring work on them we have no idea if they even still work at all afterwards All these machine types are also of hardware that has largely passed away into history and where I would not be surprised to find that e.g. the Linux kernel support was never tested on real hardware any more. After some consultation with the Linux kernel developers, we are going to deprecate: All PXA2xx machines: akita Sharp SL-C1000 (Akita) PDA (PXA270) borzoi Sharp SL-C3100 (Borzoi) PDA (PXA270) connex Gumstix Connex (PXA255) mainstone Mainstone II (PXA27x) spitz Sharp SL-C3000 (Spitz) PDA (PXA270) terrier Sharp SL-C3200 (Terrier) PDA (PXA270) tosa Sharp SL-6000 (Tosa) PDA (PXA255) verdex Gumstix Verdex Pro XL6P COMs (PXA270) z2 Zipit Z2 (PXA27x) All OMAP2 machines: n800 Nokia N800 tablet aka. RX-34 (OMAP2420) n810 Nokia N810 tablet aka. RX-44 (OMAP2420) One of the OMAP1 machines: cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) Rationale: * for QEMU dropping individual machines is much less beneficial than if we can drop support for an entire SoC * the OMAP2 QEMU code in particular is large, old and unmaintained, and none of the OMAP2 kernel maintainers said they were using QEMU in any of their testing/development * although there is a setup that is booting test kernels on some of the PXA2xx machines, nobody seemed to be using them as part of their active kernel development and my impression from the email thread is that PXA is the closest of all these SoC families to being dropped from the kernel soon * nobody said they were using cheetah, so it's entirely untested and quite probably broken * on the other hand the OMAP1 sx1 model does seem to be being used as part of kernel development, and there was interest in keeping collie around In particular, the mainstone, tosa and z2 machine types have already been dropped from Linux. Mark all these machine types as depprecated. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- docs/about/deprecated.rst | 15 +++++++++++++++ hw/arm/gumstix.c | 2 ++ hw/arm/mainstone.c | 1 + hw/arm/nseries.c | 2 ++ hw/arm/palm.c | 1 + hw/arm/spitz.c | 1 + hw/arm/tosa.c | 1 + hw/arm/z2.c | 1 + 8 files changed, 24 insertions(+)