diff mbox series

[v3,3/3] hw/core: Cleanup unused included headers in numa.c

Message ID 20240311075621.3224684-4-zhao1.liu@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series hw/core: Cleanup and reorder headers | expand

Commit Message

Zhao Liu March 11, 2024, 7:56 a.m. UTC
From: Zhao Liu <zhao1.liu@intel.com>

Remove unused header in numa.c:
* qemu/bitmap.h
* migration/vmstate.h

Note: Though parse_numa_hmat_lb() has the variable named "bitmap_copy",
it doesn't use the normal bitmap ops so that it's safe to exclude
qemu/bitmap.h header.

Tested by "./configure" and then "make".

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
v3: Re-included hw/core/cpu.h since CPU_UNSET_NUMA_NODE_ID is defined
    in this header.
---
 hw/core/numa.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé March 11, 2024, 8:50 a.m. UTC | #1
On 11/3/24 08:56, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Remove unused header in numa.c:
> * qemu/bitmap.h
> * migration/vmstate.h
> 
> Note: Though parse_numa_hmat_lb() has the variable named "bitmap_copy",
> it doesn't use the normal bitmap ops so that it's safe to exclude
> qemu/bitmap.h header.
> 
> Tested by "./configure" and then "make".
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> v3: Re-included hw/core/cpu.h since CPU_UNSET_NUMA_NODE_ID is defined
>      in this header.
> ---
>   hw/core/numa.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/hw/core/numa.c b/hw/core/numa.c
index f08956ddb0ff..81d21243498e 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -28,7 +28,6 @@ 
 #include "sysemu/numa.h"
 #include "exec/cpu-common.h"
 #include "exec/ramlist.h"
-#include "qemu/bitmap.h"
 #include "qemu/error-report.h"
 #include "qapi/error.h"
 #include "qapi/opts-visitor.h"
@@ -36,7 +35,6 @@ 
 #include "sysemu/qtest.h"
 #include "hw/core/cpu.h"
 #include "hw/mem/pc-dimm.h"
-#include "migration/vmstate.h"
 #include "hw/boards.h"
 #include "hw/mem/memory-device.h"
 #include "qemu/option.h"