| Message ID | 20240311121929.212472-5-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | crypto: handle gcrypt ciphers being disabled | expand |
On 11/03/2024 13.19, Daniel P. Berrangé wrote: > Since the ciphers can be dynamically disabled at runtime, when running > unit tests it is helpful to report which ciphers we can skipped for > testing. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/unit/test-crypto-cipher.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/unit/test-crypto-cipher.c b/tests/unit/test-crypto-cipher.c > index d0ea7b4d8e..f5152e569d 100644 > --- a/tests/unit/test-crypto-cipher.c > +++ b/tests/unit/test-crypto-cipher.c > @@ -821,6 +821,10 @@ int main(int argc, char **argv) > for (i = 0; i < G_N_ELEMENTS(test_data); i++) { > if (qcrypto_cipher_supports(test_data[i].alg, test_data[i].mode)) { > g_test_add_data_func(test_data[i].path, &test_data[i], test_cipher); > + } else { > + g_printerr("# skip unsupported %s:%s\n", > + QCryptoCipherAlgorithm_str(test_data[i].alg), > + QCryptoCipherMode_str(test_data[i].mode)); > } > } > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/unit/test-crypto-cipher.c b/tests/unit/test-crypto-cipher.c index d0ea7b4d8e..f5152e569d 100644 --- a/tests/unit/test-crypto-cipher.c +++ b/tests/unit/test-crypto-cipher.c @@ -821,6 +821,10 @@ int main(int argc, char **argv) for (i = 0; i < G_N_ELEMENTS(test_data); i++) { if (qcrypto_cipher_supports(test_data[i].alg, test_data[i].mode)) { g_test_add_data_func(test_data[i].path, &test_data[i], test_cipher); + } else { + g_printerr("# skip unsupported %s:%s\n", + QCryptoCipherAlgorithm_str(test_data[i].alg), + QCryptoCipherMode_str(test_data[i].mode)); } }
Since the ciphers can be dynamically disabled at runtime, when running unit tests it is helpful to report which ciphers we can skipped for testing. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/unit/test-crypto-cipher.c | 4 ++++ 1 file changed, 4 insertions(+)